improve version checking for v3
Do not set annex.version whenever any command is run. Just do it in init. This ensures that, if a repo has annex.version=3, it has a git-annex branch, so we don't have to run a command every time to check for the branch. Remove the old ad-hoc logic for v0 and v1, to simplify version checking.
This commit is contained in:
parent
c7a1690f02
commit
944c51ba26
4 changed files with 16 additions and 32 deletions
37
Version.hs
37
Version.hs
|
@ -7,14 +7,11 @@
|
|||
|
||||
module Version where
|
||||
|
||||
import Control.Monad.State (liftIO)
|
||||
import Control.Monad (unless)
|
||||
import System.Directory
|
||||
|
||||
import Types
|
||||
import qualified Annex
|
||||
import qualified GitRepo as Git
|
||||
import Locations
|
||||
import Config
|
||||
|
||||
type Version = String
|
||||
|
@ -31,40 +28,26 @@ upgradableVersions = ["0", "1", "2"]
|
|||
versionField :: String
|
||||
versionField = "annex.version"
|
||||
|
||||
getVersion :: Annex Version
|
||||
getVersion :: Annex (Maybe Version)
|
||||
getVersion = do
|
||||
g <- Annex.gitRepo
|
||||
let v = Git.configGet g versionField ""
|
||||
if not $ null v
|
||||
then return v
|
||||
else do
|
||||
-- version 0 was not recorded in .git/config;
|
||||
-- such a repo should have an gitAnnexDir but no
|
||||
-- gitAnnexObjectDir.
|
||||
--
|
||||
-- version 1 may not be recorded if the user
|
||||
-- forgot to init. Such a repo should have a
|
||||
-- gitAnnexObjectDir already.
|
||||
d <- liftIO $ doesDirectoryExist $ gitAnnexDir g
|
||||
o <- liftIO $ doesDirectoryExist $ gitAnnexObjectDir g
|
||||
case (d, o) of
|
||||
(True, False) -> return "0"
|
||||
(True, True) -> return "1"
|
||||
_ -> do
|
||||
setVersion
|
||||
return defaultVersion
|
||||
then return $ Just v
|
||||
else return Nothing
|
||||
|
||||
setVersion :: Annex ()
|
||||
setVersion = setConfig versionField defaultVersion
|
||||
|
||||
checkVersion :: Annex ()
|
||||
checkVersion = do
|
||||
v <- getVersion
|
||||
unless (v `elem` supportedVersions) $ do
|
||||
error $ "Repository version " ++ v ++
|
||||
" is not supported. " ++
|
||||
msg v
|
||||
checkVersion = getVersion >>= handle
|
||||
where
|
||||
handle Nothing = error "First run: git-annex init"
|
||||
handle (Just v) = do
|
||||
unless (v `elem` supportedVersions) $ do
|
||||
error $ "Repository version " ++ v ++
|
||||
" is not supported. " ++
|
||||
msg v
|
||||
msg v
|
||||
| v `elem` upgradableVersions = "Upgrade this repository: git-annex upgrade"
|
||||
| otherwise = "Upgrade git-annex."
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue