mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix regression in addurl --fast caused by youtube-dl support

Browse source 
Similar to c6e4bc0a22 but another code
path. As well as using youtube-dl unecessarily, it used the filename it
comes up with, which while nice for youtube videos, is not right for
other files.

This means more work is done for urls that youtube-dl does support,
but is probably more efficient for other urls, since it only downloads
the first chunk of content, while youtube-dl probably downloads more.

This commit was supported by the NSF-funded DataLad project.
This commit is contained in:
Joey Hess 2017-12-08 14:49:55 -04:00
parent 5b98da60b1
commit 8990afaef0
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 46 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

6
doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls/comment_2_1cebe1385d2b8a244afc259a78f72ada._comment Normal file
View file

@ -0,0 +1,6 @@
[[!comment format=mdwn
username="joey"
subject="""comment 2"""
date="2017-12-06T16:02:55Z"
content="""
"""]]

8
doc/bugs/regression_-_yt__58___prefix_for___34__regular__34___urls/comment_4_f05e1047c5d22dddba21a9faa3397f0d._comment Normal file
View file

@ -0,0 +1,8 @@
[[!comment format=mdwn
username="joey"
subject="""comment 4"""
date="2017-12-08T18:48:46Z"
content="""
That one happened with `git annex addurl --fast $url` so a different code
path. Had to add a html page check to youtubeDlFileName to fix it.
"""]]