mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

rethink

Browse source
This commit is contained in:
Joey Hess 2018-10-29 17:09:55 -04:00
parent 7a050660d6
commit 87d770e3fd
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
doc/todo/do_not_allow_using_stop_in_CommandPerform.mdwn
View file

@ -17,3 +17,20 @@ CommandPerform. Simply change the type:
+ stop :: CommandStart
And follow the compile errors.
> Hmm, I tried doing this, and I was not finding any other places
> that stopped without emitting some kind of warning or informational
> message.
>
> And on second thought, this use of stop behaves the same as
> `next (return False)`, or as having a CommandCleanup that
> returns False without displaying any indication why.
>
> So compprehensively fixing it would probably need to involve
> returning something other than False from CommandCleanup, like a message
> to display, but with only one case of the problem currently, I don't think it's
> worth the bother to do that. Also, there are lots of different ways it
> makes sense to display different messages in different situations and so
> returning a message to display feels wrong.
>
> Guess I'm not going to do this. [[done]] --[[Joey]]