mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix init default description reversion

Browse source 
init: Fix a reversion in the last release that prevented automatically
generating and setting a description for the repository.

Seemed best to factor out uuidDescMapRaw that does not
have the default mempty descrition behavior.

I don't much like that behavior, but I know things depend on it.
One thing in particular is `git annex info` which lists the uuids and
descriptions; if the current repo has been initialized in some way that
means it does not have a description, it would not show up w/o that.

(Not only repos created due to this bug might lack that. For example a repo
that was marked dead and had --drop-dead delete its git-annex branch info,
and then came back from the dead would similarly not be in the uuid.log.
Also there have been other versions of git-annex that didn't set a default
description; for years there was no default description.)
This commit is contained in:
Joey Hess 2019-06-20 20:30:24 -04:00
parent 7264203eb1
commit 84e729fda5
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 28 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/annex_init_no_longer_generates_default_description.mdwn
View file

@ -94,3 +94,5 @@ init ok
```
Note that the description for here is a blank string.
> [[fixed|done]] --[[Joey]]

13
doc/bugs/annex_init_no_longer_generates_default_description/comment_3_6edae77c6ee7e4c4f94f9c0daff375ad._comment Normal file
View file

@ -0,0 +1,13 @@
[[!comment format=mdwn
username="joey"
subject="""comment 3"""
date="2019-06-21T00:12:51Z"
content="""
Thanks Kyle, that does point at the problem. In uuidDescMapLoad
it implicitly adds the UUID of the current repo, with an empty
description if none is set. So, the added check of uuidDescMap
always finds the UUID in it already. Your uuidDescMapLoad hack
avoids this by loading the map before the current repo has a UUID.
Fixed more cleanly..
"""]]