mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

update re state of bs branch

Browse source
This commit is contained in:
Joey Hess 2019-12-06 15:13:13 -04:00
parent 5f391179f1
commit 8051deb352
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
doc/todo/optimize_by_converting_String_to_ByteString.mdwn
View file

@ -3,12 +3,13 @@ Converting to ByteString, and RawFilePath, should speed it up
significantly, according to [[/profiling]]. significantly, according to [[/profiling]].
I've made a test branch, `bs`, to see what kind of performance improvement I've made a test branch, `bs`, to see what kind of performance improvement
to expect. Most commands don't built yet in that branch, but `git annex to expect.
find` does. Speedups range from 28-66%. The files fly by much more
snappily.
As well as adding back all the code that was disabled to get it to build, Benchmarking `git-annex find`, speedups range from 28-66%. The files fly by
the `bs` branch has quite a lot of things still needing work, including: much more snappily. Other commands likely also speed up, but do more work
than find so the improvement is not as large.
The `bs` branch is in a mergeable state now, but still needs work:
* Eliminate all the fromRawFilePath, toRawFilePath, encodeBS, * Eliminate all the fromRawFilePath, toRawFilePath, encodeBS,
decodeBS conversions. Or at least most of them. There are likely decodeBS conversions. Or at least most of them. There are likely
@ -19,7 +20,9 @@ the `bs` branch has quite a lot of things still needing work, including:
* keyFile uses fromRawFilePath and that adds around 3% overhead in `git-annex find`. * keyFile uses fromRawFilePath and that adds around 3% overhead in `git-annex find`.
Converting it to a RawFilePath needs a version of `</>` for RawFilePaths. Converting it to a RawFilePath needs a version of `</>` for RawFilePaths.
* getJournalFileStale uses fromRawFilePath, and adds 3-5% overhead in * getJournalFileStale uses fromRawFilePath, and adds 3-5% overhead in
`git-annex whereis`. Converting it to RawFilePath needs a version of `</>` for RawFilePaths. `git-annex whereis`. Converting it to RawFilePath needs a version
of `</>` for RawFilePaths. It also needs a ByteString.readFile
for RawFilePath.
* System.FilePath is not available for RawFilePath, and many of the * System.FilePath is not available for RawFilePath, and many of the
conversions are to get a FilePath in order to use that library. conversions are to get a FilePath in order to use that library.