mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Improve local pairing behavior when two computers both try to start the pairing process separately.

Browse source 
I was able to reproduce something very like this bug by starting
pairing separately on both computers under poor network conditions (ie,
weak wifi on my front porch). Neither computer showed an alert for the
PairReq messages it was seeing (intermittently) from the other.

So, I've made a new PairReq message that has not been seen before
always make the alert pop up, even if the assistant thinks it is
in the middle of its own pairing process (or even another pairing
process with a different box on the LAN).

(This shouldn't cause a rogue PairAck to disrupt a pairing process part
way through.)
This commit is contained in:
Joey Hess 2013-11-02 15:10:29 -04:00
parent b5ddb4f0e6
commit 7e7e765cba
4 changed files with 42 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

14
doc/bugs/Local_pairing_fails:_received_PairMsg_loop.mdwn
View file

@ -23,3 +23,17 @@ I'm on Ubuntu Raring 13.04. I installed git-annex 4.20131024 from the Precise P
...and so on and so on...
# End of transcript or log.
"""]]
> I was able to reproduce something very like this by starting
> pairing separately on both computers under poor network conditions (ie,
> weak wifi on my front porch).
>
> So, I've made a new PairReq message that has not been seen before
> always make the alert pop up, even if the assistant thinks it is
> in the middle of its own pairing process (or even another pairing process
> with a different box on the LAN).
>
> (This shouldn't cause a rogue PairAck to disrupt a pairing process part
> way through.)
>
> [[done]] --[[Joey]]