mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fromkey: Made idempotent

Browse source 
If the worktree file already exists, and is annexed and uses the same
key, avoid failing, nothing needs to be done.

Had to add lookupFileNotHidden to handle the case where an adjust --hide-missing
is in use, and the worktree file was hidden due to the object content
being missing. lookupFile would return the key of the hidden file,
but it makes sense that after fromkey succeeds, the worktree must
contain the file it was supposed to set up.
This commit is contained in:
Joey Hess 2019-02-05 13:13:09 -04:00
parent 995628d94a
commit 7b46b43c48
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
4 changed files with 35 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/todo/git-annex-fromkey_behavior_when_target_file_exists.mdwn
View file

@ -1 +1,3 @@
Currently, git-annex-fromkey errors if the target file exists. It would help if, when the target file is the same symlink that would be created by the command (i.e. to the same key), this wasn't considered an error. Together with [[todo/batch_command_result_status]] this would make the command a more robust building block for higher-level operations.
> idempotency is good, [[done]] --[[Joey]]