This commit is contained in:
Joey Hess 2021-06-04 13:53:24 -04:00
parent 327033c2e5
commit 7868dbd5e0
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 37 additions and 0 deletions

View file

@ -0,0 +1,11 @@
[[!comment format=mdwn
username="joey"
subject="""comment 17"""
date="2021-06-04T17:37:30Z"
content="""
The scan could be done lazily, but there are situations that use the
database where unexpectedly taking a much longer time than usual
would be a real problem. For example "git add".
The bloom filter idea does not work.
"""]]

View file

@ -0,0 +1,12 @@
[[!comment format=mdwn
username="joey"
subject="""comment 3"""
date="2021-06-04T17:45:21Z"
content="""
It is not very useful to detect if a key is used by more than one file if
you don't know the files. In any case, yes, the keys db is used for a large
number of things, when it comes to unlocked files.
[[todo/numcopies_check_other_files_using_same_key]] has some thoughts on
--all, but I doubt it will make sense to change --all.
"""]]

View file

@ -0,0 +1,14 @@
[[!comment format=mdwn
username="joey"
subject="""comment 4"""
date="2021-06-04T17:49:43Z"
content="""
Keys with extensions do not necessarily have the same extension as used in
the worktree files that include/exclude match on.
I'm not sure why all these wild ideas are being thrown out there when this
todo is about a specific, simple improvement that will speed up the git
part of the scanning by about 3x? It's like you somehow consider this an
emergency where increasingly wild measures have to be taken to prevent me
from making a terrible mistake?
"""]]