mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

analysis

Browse source
This commit is contained in:
Joey Hess 2011-03-18 16:47:20 -04:00
parent 69841b67c9
commit 75ad0f22d8
1 changed files with 22 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
doc/bugs/fsck_output.mdwn
View file

@ -1,16 +1,28 @@
When you check several files and the fsck fails, you get confusing output:
<pre>
fsck test1 (checksum...)
Only 1 of 2 trustworthy copies of test1 exist.
Back it up with git-annex copy.
failed
fsck test2 (checksum...)
Only 1 of 2 trustworthy copies of test2 exist.
Back it up with git-annex copy.
failed
O fsck test1 (checksum...)
E Only 1 of 2 trustworthy copies of test1 exist.
E Back it up with git-annex copy.
O
O failed
O fsck test2 (checksum...)
E Only 1 of 2 trustworthy copies of test2 exist.
E Back it up with git-annex copy.
O
O failed
</pre>
The newline is in the wrong place and confuses the user. It should be printed _after_ "failed".
> This is a consequence of part of the output being printed to stderr, and
> part to stdout. I've marked the lines above with E and O.
>
> Normally a "failed" is preceeded by a message output to stdout desribing
> the problem; such a message will not be "\n" terminated, so a newline
> is always displayed before "failed". In this case, since the message
> is sent to stderr, it is newline terminated.
>
> Fixing this properly would involve storing state, or rethinking
> when git-annex displays newlines (and I rather like its behavior
> otherwise). --[[Joey]]