Added a comment
This commit is contained in:
		
					parent
					
						
							
								dce215e11a
							
						
					
				
			
			
				commit
				
					
						73cc3fcd12
					
				
			
		
					 1 changed files with 43 additions and 0 deletions
				
			
		|  | @ -0,0 +1,43 @@ | ||||||
|  | [[!comment format=mdwn | ||||||
|  |  username="jpds" | ||||||
|  |  avatar="http://cdn.libravatar.org/avatar/24d746ec6a7726b162c12ecceb3ee267" | ||||||
|  |  subject="comment 3" | ||||||
|  |  date="2023-01-19T16:28:19Z" | ||||||
|  |  content=""" | ||||||
|  | I believe the fix for this is: | ||||||
|  | 
 | ||||||
|  | ``` | ||||||
|  | diff --git a/Remote/S3.hs b/Remote/S3.hs | ||||||
|  | index f5014202e..49f2ebd58 100644 | ||||||
|  | --- a/Remote/S3.hs | ||||||
|  | +++ b/Remote/S3.hs | ||||||
|  | @@ -948,8 +948,8 @@ s3Configuration c = cfg | ||||||
|  |                         | otherwise -> AWS.HTTP | ||||||
|  |         cfg = case getRemoteConfigValue signatureField c of | ||||||
|  |                 Just (SignatureVersion 4) -> | ||||||
|  | -                       S3.s3v4 proto endpoint False S3.SignWithEffort | ||||||
|  | -               _ -> S3.s3 proto endpoint False | ||||||
|  | +                       S3.s3v4 proto datacenter False S3.SignWithEffort | ||||||
|  | +               _ -> S3.s3 proto datacenter False | ||||||
|  | 
 | ||||||
|  |  data S3Info = S3Info | ||||||
|  |         { bucket :: S3.Bucket | ||||||
|  | ``` | ||||||
|  | 
 | ||||||
|  | ...however I cannot test it myself right now as it's failing to compile on another bit of code: | ||||||
|  | 
 | ||||||
|  | ``` | ||||||
|  | [452 of 679] Compiling Remote.S3 | ||||||
|  | 
 | ||||||
|  | git/joeyh/git-annex.branchable.com/Remote/S3.hs:922:68: error: | ||||||
|  |     • Couldn't match type ‘B8.ByteString’ with ‘[Char]’ | ||||||
|  |       Expected type: String | ||||||
|  |         Actual type: B8.ByteString | ||||||
|  |     • In the first argument of ‘T.pack’, namely ‘datacenter’ | ||||||
|  |       In the second argument of ‘($)’, namely ‘T.pack datacenter’ | ||||||
|  |       In the expression: AWS.s3HostName $ T.pack datacenter | ||||||
|  |     | | ||||||
|  | 922 |                 | h == AWS.s3DefaultHost = AWS.s3HostName $ T.pack datacenter | ||||||
|  |     |                                                                    ^^^^^^^^^^ | ||||||
|  | ``` | ||||||
|  | """]] | ||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 jpds
				jpds