mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix obviously wrong attoparsec parser

Browse source 
takeByteString can only be used at the end of a parser, not before other
input. This was a dumb enough mistake that I audited the rest of the
code base for similar mistakes. Pity that attoparsec cannot avoid it at
the type level.

Fixes git-annex forget propagation between repositories. (reversion
introduced in version 7.20190122)

Sponsored-by: Brock Spratlen on Patreon
This commit is contained in:
Joey Hess 2022-02-07 14:09:43 -04:00
parent 65ca0b49d6
commit 6992250d63
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 31 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/sync_does_not_propagate_forgetfulness.mdwn
View file

@ -31,3 +31,5 @@ Reproduction script:
git-annex log foo
--[[Joey]]
> [[fixed|done]] --[[Joey]]

9
doc/bugs/sync_does_not_propagate_forgetfulness/comment_1_acc9744be183c297c6410f9b0a30b46b._comment Normal file
View file

@ -0,0 +1,9 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2022-02-07T17:49:37Z"
content="""
Reversion introduced in [[!commit 2eadb6cd68073a905e8ff32cc8093a43d0b05c81]].
Parsing of the transitions log silently failed, so all propagation of
transitions was broken.
"""]]