mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

comment and bug report

Browse source
This commit is contained in:
Joey Hess 2022-02-07 12:27:50 -04:00
parent d9b55be624
commit 697114c234
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 29 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
doc/bugs/unnecessary_work_when_drop_cannot_possibly_succeed.mdwn Normal file
View file

@ -0,0 +1,12 @@
When annex.numcopies is 4, and there are only 4 copies of a file,
`git-annex drop` behaves like this:
drop me (locking a2...) (locking a3...) (locking a4...) (unsafe)
Could only verify the existence of 3 out of 4 necessary copies
That is unncessary work, because the drop cannot possibly succeed when
there are not more than numcopies. It should be able to skip locking the
content on remotes and immediately fail.
A user reported a situation where this happened to a lot of files and
caused rate limiting and slowed down git-annex sync. --[[Joey]]

17
doc/forum/Different_preferred_content_for_subdirs/comment_1_5c1e1e6375360cc9416821085b5a68a8._comment Normal file
View file

@ -0,0 +1,17 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2022-02-07T16:18:56Z"
content="""
You are not supposed to quote the pattern after 'include='
So, what your expression actually says is if there is a directory
named `"documents/` that contains files ending in `"`,
to apply `not (copies=archive:4)`.
I am kind of surprised that the original situation would lead to any churn
though. It seems like, since it knows there are at most 3, copies, and 4
copies are required, it should be able to skip trying to drop at all.
Instead it does unncessary work. Filed a bug,
[[bugs/unnecessary_work_when_drop_cannot_possibly_succeed]].
"""]]