comment and bug report
This commit is contained in:
parent
d9b55be624
commit
697114c234
2 changed files with 29 additions and 0 deletions
|
@ -0,0 +1,12 @@
|
|||
When annex.numcopies is 4, and there are only 4 copies of a file,
|
||||
`git-annex drop` behaves like this:
|
||||
|
||||
drop me (locking a2...) (locking a3...) (locking a4...) (unsafe)
|
||||
Could only verify the existence of 3 out of 4 necessary copies
|
||||
|
||||
That is unncessary work, because the drop cannot possibly succeed when
|
||||
there are not more than numcopies. It should be able to skip locking the
|
||||
content on remotes and immediately fail.
|
||||
|
||||
A user reported a situation where this happened to a lot of files and
|
||||
caused rate limiting and slowed down git-annex sync. --[[Joey]]
|
|
@ -0,0 +1,17 @@
|
|||
[[!comment format=mdwn
|
||||
username="joey"
|
||||
subject="""comment 1"""
|
||||
date="2022-02-07T16:18:56Z"
|
||||
content="""
|
||||
You are not supposed to quote the pattern after 'include='
|
||||
|
||||
So, what your expression actually says is if there is a directory
|
||||
named `"documents/` that contains files ending in `"`,
|
||||
to apply `not (copies=archive:4)`.
|
||||
|
||||
I am kind of surprised that the original situation would lead to any churn
|
||||
though. It seems like, since it knows there are at most 3, copies, and 4
|
||||
copies are required, it should be able to skip trying to drop at all.
|
||||
Instead it does unncessary work. Filed a bug,
|
||||
[[bugs/unnecessary_work_when_drop_cannot_possibly_succeed]].
|
||||
"""]]
|
Loading…
Add table
Add a link
Reference in a new issue