mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

bugs/blake3_hash_support: reroll patch, add comment

Browse source
This commit is contained in:
edef 2022-12-16 14:52:25 +00:00
parent 94329160f3
commit 654863027f
2 changed files with 232 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

23
doc/bugs/blake3_hash_support/comment_3_a28c55a1d6158e301cc63d6087d8ab0e._comment Normal file
View file

@ -0,0 +1,23 @@
[[!comment format=mdwn
username="edef"
subject="""comment 3"""
date="2022-12-16T13:53:04Z"
content="""
> I do think it would make sense to include "256" in the name of the backend,
> unless BLAKE3 recommends against using other lengths for some good reason.
Done.
> Going the current route with adding a blake3 depdenency would need to start
> with it as a build flag..
I've added a followup patch that makes blake3 into a build flag. I'm
happy to roll with that for now, if that gets code merged. I'm not
particularly satisfied by the existing BLAKE3 libraries for Haskell,
so I might opt to roll a nicer one with proper parallelism when I have
some time to spare.
It appears that some flags switch between a vendored library copy and
an external dependency (namely, the git-lfs flag), maybe that's an
alternative option for the interim?
"""]]