mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

export --json: Fill in the file field

Browse source 
Like import was using ActionItemWorkTreeFile, it's ok to use it for export,
even though it might not correspond with a file in the work tree.
And renamed it to ActionItemTreeFile to make that clearer.

Note that when an export has to rename files, it still uses
ActionItemOther, so file will still be null in that case, but as no file is
being transferred, that seems ok.
This commit is contained in:
Joey Hess 2021-03-12 14:09:19 -04:00
parent f87c63d998
commit 6481991208
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
10 changed files with 37 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/JSON_results_for___96__export__96___have_file__58__null_property.mdwn
View file

@ -22,3 +22,5 @@ This behavior was observed using the 4shared service, but I believe git-annex kn
Thx!
[[!tag projects/datalad]]
> [[fixed|done]] --[[Joey]]

12
doc/bugs/JSON_results_for___96__export__96___have_file__58__null_property/comment_1_bf743f047b8063b8ecbd8c87d12fa475._comment Normal file
View file

@ -0,0 +1,12 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2021-03-12T18:09:48Z"
content="""
I've fixed this.
However, there is still a case where the file field is null, which is when
an already exported file is renamed. Since nothing is transferred in that
case, and 2 files are involved which doesn't fit the one file in the json,
I left it as-is.
"""]]