mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Bugfix: Direct mode no longer repeatedly checksums duplicated files.

Browse source 
Fixed by storing a list of cached inodes for a key, instead of just one.

Backwards compatability note: An old git-annex version will fail to parse
an inode cache file that has been written by a new version, and has
multiple items. It will succees if just one. So old git-annexes will have
even worse behavior when there are duplicated files, if that is possible.
I don't think it will be a problem. (Famous last words.)

Also, note that it doesn't expire old and unused inode caches for a key.
It would be possible to add this if needed; just look through the
associated files for a key and if there are more cached inodes, throw out
any not corresponding to associated files. Unless a file is being copied
repeatedly and the old copy deleted, this lack of expiry should not be a
problem.
This commit is contained in:
Joey Hess 2013-04-06 16:01:39 -04:00
parent 54d7637b3a
commit 602baae12e
6 changed files with 56 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

3
doc/bugs/Direct_mode_keeps_re-checksuming_duplicated_files.mdwn
View file

@ -20,3 +20,6 @@ Secondly, the sync can take quite a while if you have lots of duplicates or a lo
##What version of git-annex are you using? On what operating system?
git-annex version: 4.20130227 on Archlinux
> [[done]]; fixed inode caching code to support multiple files for the
> same content. --[[Joey]]