Improve pid locking code to work on filesystems that don't support hard links.

Probing for hard link support in the pid locking code is redundant since
git-annex init already probes that. But, it didn't seem worth threading
that data through; the pid locking code runs at most once per git-annex
process, and only on unusual filesystems. Optimising a single hard link
and unlink isn't worth it.

This commit was sponsored by Francois Marier on Patreon.
This commit is contained in:
Joey Hess 2017-02-10 15:21:58 -04:00
parent 913b3b51e3
commit 5e6ced7d0f
No known key found for this signature in database
GPG key ID: C910D9222512E3C7
3 changed files with 36 additions and 5 deletions

View file

@ -0,0 +1,13 @@
[[!comment format=mdwn
username="joey"
subject="""comment 2"""
date="2017-02-10T18:52:59Z"
content="""
I was able to reproduce the problem with a FAT filesystem
mounted on Linux, if I manually enabled annex.pidlock
before git-annex init. Hard linking does not work on FAT, so that
matches my earlier guess.
I've committed a fix for this, so try again with a recent autobuild of
git-annex and it will probably fix your problem.
"""]]