From 5d4c2354745c6ae50b56bcd52e20ac4ab23f6e34 Mon Sep 17 00:00:00 2001
From: Joey Hess <joeyh@joeyh.name>
Date: Thu, 14 Apr 2016 17:39:48 -0400
Subject: [PATCH] response

---
 ...eb15c0031c18ba6d0922bb7ae8ed3._comment.swo | Bin 0 -> 16384 bytes
 ..._35eeb15c0031c18ba6d0922bb7ae8ed3._comment |  89 ++++++++++++++++++
 2 files changed, 89 insertions(+)
 create mode 100644 doc/bugs/shouldn__39__t_keep_permissions_of_the_ssh_remote__63__/.comment_1_35eeb15c0031c18ba6d0922bb7ae8ed3._comment.swo
 create mode 100644 doc/bugs/shouldn__39__t_keep_permissions_of_the_ssh_remote__63__/comment_1_35eeb15c0031c18ba6d0922bb7ae8ed3._comment

diff --git a/doc/bugs/shouldn__39__t_keep_permissions_of_the_ssh_remote__63__/.comment_1_35eeb15c0031c18ba6d0922bb7ae8ed3._comment.swo b/doc/bugs/shouldn__39__t_keep_permissions_of_the_ssh_remote__63__/.comment_1_35eeb15c0031c18ba6d0922bb7ae8ed3._comment.swo
new file mode 100644
index 0000000000000000000000000000000000000000..66b87434fd6aee115f4d327e1f0da549b1ce1fdf
GIT binary patch
literal 16384
zcmeHOO^h5z6|NXU*npGBfXMM>y-L>JnckkCUGJ{FCTlyGMYh+<`bT7AwQIU-cG}z1
z)pYmlcnCPxKoAE6HzW`ehj2jTMotJJaRHJ8AR#3jkcbdMh+~j~fbUiHj3>M6wTw9+
zt4I4y&(zPWS6@}Vs`sY0<z87mPsg05!0QPio_y?ytMcTMc;}oDH?$gX^4(s6Ot-RJ
zrgtlMiv`YRsXx0J=2aQT>gH^q{n=J;Gn>six)%kp=QS2RFZZ^TO1wm+-7w2S9cP|y
zdwEBBS=RAV)z!K3y!nRb&HB3ARdMdsyvCeTt=gRLx{aD&TWHDoz+J4@TdiYKEvTU3
zctzQ}=~?EN3_NfQ^zwFf;h<>LYcBWg@Z?kUi9?qkxNepmDj6slC>bajC>bajC>baj
zC>bajxHAKJazMO{>;pxS3&r!H9nTLH-#=D7y&d_**YZ&^P%=<5P%=<5P%=<5P%=<5
zP%=<5P%=<5P%`j;$bbxlcmvM;!H1z7e*Yi(|9^R0h~EQ01-=h_8#o7i3iu@OtH*?R
z9r!U20Z#*eI4Hz#f!_dc0>1{n3Y-KE0q=ZVh_`_s0<QoXxB{F49t9o(-baApkHFi&
z&w$r}Zvq~08gPN5z(L@>M}_z+@GkHg-~-oyCxL%W2=Nc#b>J1?IM4w8^id(c1$-WO
z{}Ca60(=8#0jGdT;9=m;9}(gQz%Af1&;%X<{t2Gm0)7O%3cL&qfad__aO1;5ya0Rw
z_%!fKaC-}IfkVJA5NPQERp1ct9s(`D1HK1*7kC%=4${94eC>cBe$DV(s(cl0tAN5d
z*MzGONJ(@S<~kivKa3*k$Zf?LVS4vU`;_?avi4D?s{=(cxY5gUsNa&A+NX(ok`s`Q
z1q<WXy|c7iF&4PLto?KEG#-1mBv{z}>uscj+3Dd^$2l&<TusAVUBm^NwJmCgk)mY^
z+vmwo!z77R@L43S4=^HKu~)sl((X-`kw65!?o*%pSB2@=Pm0Ye6#gG*JjVRe5;4;k
zW!|CcNm}7MPjpJ_NSNl#`^;e#2VvWOo|u@BL2w>RCZi3~{aB^XD`^tw+NcQMfZA5J
zRG*u(ADyDWrX~;L9fj?Db&aM7(=TifSP?E~r^6Ht8;>$I5<LAP$|_dXJe{W<!lfxp
z7`|ggy{^o*j*JT5MT?0kdePJ<#O+pLC~3OT)S*n}tmf%d$sE_d&U1T(q7xItVpDq+
zBUjh!N2prmOsgruP;TN&m=_K0<fWBLe@hj)hr@Ops5W)Oc(dQAd!JidzvQj0o2u3E
zQTf22*fBx=zGPG<b~e4|keIe;tgUJAP)vrI8M-~vb_|H6u0+v#N2ai>V*|de!vN!+
zr-M6>|E|V1KG3lWZKk@H3@2a3&P8KYcoG%aqwki7XP>3&;zDJSW@>J;Qd=M-v{R+N
zqzWrAG)28QQdzc_Iie}67*)+C*T!t9P^*VgjA5;0U{Yn0q&i7MnJcTN<%U{eo)O64
zIpENxPMBdikK|qLs2I~ZRZeCYd;azYih`(8F~SYaw?)M|$5zYhEkIv%VK1p_#Lhs?
zv0I8f<G8$xBHcGSVKQO<k&LmmU~f+QA-2C%wIk){rZuxd?82??7G?$UEU<!XL3*i5
z7j)W1?f~RO+TY4Xtw9AD;}4dGH8%Wl^Jd0{Fe{v7IkE3BIq17FO=rTCw+u>54v*$S
zy>g6Z78dZ1uRgC!H7trQ@ZlrCfn%BaGTJg9H?Gn0i4$PL3bCsfCzQNX%u|Wd0Lt)K
z*u=4+I5Ab&Ne659Y?x!_w8KrS>X;N**6Ce!M<!On5)93)G<9d}`?#$QyNOP7IwN!G
zoWjg0O6+3?ip~@j$2BXGzSxtnWg&<+BpHcJV|}4APcsd-QgfNdqBMHv?CgW7LOVyK
zvLl&|B#%^)j<M}wi#KgLoSxCN?TvkZsd|{stz0;JdFAYLbo$~&I$ZsVm1y5-_!Tqo
zT<EJfLl1f|hpCyPXD?i)vlq|Nwo3UjE;UG})Co5+pY4R?F3xce=PJDBZKJSQty!be
ztWnA7Sca>x(Q>bh5Dng>`DU}}*5@2&vDKJswHB!6x=1rJv5mE1;&FX=mxSGIiFI9}
zRSI<cOpd*9ix0<G=ZVby&T%YC*oJN*u?&%zYfY_G%fJ!R?9teS?Wx-D$avG7tF7$<
z)%d1q-gO<p^KndS1xGBjXb$4i7SB5}e<riL>HK`t7=rGg*q_j_d+ZoYDR!t!IMHWN
z2zD{YVj6H8T?wVp*B)#JpZM)=+UJYX)Ee)OL#KLq1zrVSLa@0&HC7L9fjxPf`bKx%
zHlIiSgl^q1wn$Tiy^@<ThM$L6VZaAER${eH1Kq=V<)zqzeI2u+V<+}e#lB9Xz*y6m
zJ7@2Di!<1iASNXk?-q^}FzMSmg42@euCnHlyP8t0l(Bc9!1RTcVypET65?tn^gEW%
zrt4yKVbP40bi}A7n`+q0SX&+h(=!%AKFlN7Gm=~28N&TunwkR+T6cu#^G0DR73A;?
zNoAb170O`?ViRl3Iiw7oFh|(o!H7~<p)ib`Y0r!T8Z_)fXWp0;vGOJbvU%b|Y^rh@
z#wrj@G#^@*CnqNb1u(hGlXbT?Uv-<+TJuufU1~O#+_@K!nf1)@amnI#JJn1rCNh>?
z)Z|<DlVW4zsbPUOZyot^H|WQL{r|tgH=l$5&i+5#YV-OxeEgpSUk2uZza#%G;7#CF
zU<Ei1a6K0&UnK)210@3`10@3`10@3`10@3`10@3`0}l!V@G2*-T@&nZ-~QwX_`)Vk
zV13;HG2{qg6nL|6tw#<yqQ`KkbwWk(!SBHJEkc^`-q{r&h?OYgA2#6++Xx4TVAwfF
z<TdSZNCTCPi#>g02LEoJ<6-3BStJWFj3^AfbwoQ6vV~{O|1q99;yP5i63R>6<hlte
zLq6gI95IHouKJWj(nmnyIzo@bV$cV^G^>IjLSW*%Lfy>SyN)PJlpo@08$j$Q>m>*X
zAY`3|v2TJmN4p4=<wv<{rkx|ShWLjGXA2_{vN=*PR2ZRyyrYZOl2pNq-$sE1F}>nH
r;T@V@js2)+BP1PVB1eXRD*v`>0=*^xo^#099|ntTo1@XP3JdWcrR1<k

literal 0
HcmV?d00001

diff --git a/doc/bugs/shouldn__39__t_keep_permissions_of_the_ssh_remote__63__/comment_1_35eeb15c0031c18ba6d0922bb7ae8ed3._comment b/doc/bugs/shouldn__39__t_keep_permissions_of_the_ssh_remote__63__/comment_1_35eeb15c0031c18ba6d0922bb7ae8ed3._comment
new file mode 100644
index 0000000000..33047adf9f
--- /dev/null
+++ b/doc/bugs/shouldn__39__t_keep_permissions_of_the_ssh_remote__63__/comment_1_35eeb15c0031c18ba6d0922bb7ae8ed3._comment
@@ -0,0 +1,89 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 1"""
+ date="2016-04-14T20:43:05Z"
+ content="""
+umask 077 means a file will be mode 400. The 400 mode is indeed retained
+when that object is transferred to another repository.
+
+git-annex does make sure that the file can be read by the current user.
+Which mode 400 does allow.
+
+Did your problem involve some other user needing to read the file? 
+If you configure core.sharedrepository group or world, then git-annex
+will adjust the mode of the received object to let the group or everyone
+read it.
+
+----
+
+The simplest way to make it use the umask would be this patch. But,
+with this patch, if I have a file that's mode 664 and my umask is 077, git
+annex add will change the file mode to 600.
+So, I don't like this patch; its impact is too broad.
+
+    diff --git a/Annex/Perms.hs b/Annex/Perms.hs
+    index 6444025..9b35bb8 100644
+    --- a/Annex/Perms.hs
+    +++ b/Annex/Perms.hs
+    @@ -5,6 +5,8 @@
+      - Licensed under the GNU GPL version 3 or higher.
+      -}
+     
+    +{-# LANGUAGE CPP #-}
+    +
+     module Annex.Perms (
+     	setAnnexFilePerm,
+     	setAnnexDirPerm,
+    @@ -28,6 +30,10 @@ import Git.SharedRepository
+     import qualified Annex
+     import Config
+     
+    +#ifndef mingw32_HOST_OS
+    +import Data.Bits
+    +#endif
+    +
+     withShared :: (SharedRepository -> Annex a) -> Annex a
+     withShared a = a =<< coreSharedRepository <$> Annex.getGitConfig
+     
+    @@ -82,7 +88,7 @@ createAnnexDirectory dir = walk dir [] =<< top
+     			setAnnexDirPerm p
+     
+     {- Normally, blocks writing to an annexed file, and modifies file
+    - - permissions to allow reading it.
+    + - permissions to not allow writing it and otherwise reflect the umask.
+      -
+      - When core.sharedRepository is set, the write bits are not removed from
+      - the file, but instead the appropriate group write bits are set. This is
+    @@ -98,9 +104,18 @@ freezeContent file = unlessM crippledFileSystem $
+     		addModes [ownerReadMode, groupReadMode, ownerWriteMode, groupWriteMode]
+     	go AllShared = liftIO $ void $ tryIO $ modifyFileMode file $
+     		addModes (readModes ++ writeModes)
+    -	go _ = liftIO $ modifyFileMode file $
+    -		removeModes writeModes .
+    -		addModes [ownerReadMode]
+    +#ifndef mingw32_HOST_OS
+    +	go _ = liftIO $ bracket
+    +		(liftIO $ setFileCreationMask 0o22) -- set umask to get it
+    +		(liftIO . setFileCreationMask) 
+    +		$ \umask -> modifyFileMode file $
+    +			removeModes writeModes .
+    +			(\mode -> mode .&. complement umask)
+    +#else
+    +	go _ = liftIO $ modifyFileMode file $ 
+    +			removeModes writeModes .
+    +			addModes [ ownerReadMode ]
+    +#endif
+     
+     isContentWritePermOk :: FilePath -> Annex Bool
+     isContentWritePermOk file = ifM crippledFileSystem
+
+The umask-based mode setting could be put into every remote
+that uses a transfer method that preserves permissions. (Including the
+external special remote I suppose, since it *might* do so.) Or put in
+`gitViaTmp` but there are a few places `getViaTmp` is used that do not
+involve transfers from remotes.
+
+Also this would add the overhead of umask()+stat()+chmod()+umask()
+to every file downloaded by git-annex, on top of the chmodding it already
+does.
+"""]]