mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

proxied exporttree=yes remotes are untrustworthy

Browse source 
This is not perfect because it does not handle versioned special
remotes, which should not be untrustworthy, but now are when proxied.

The implementation turned out to be easy, because the exporttree field
is a default field, so is available in RemoteConfig even for git
remotes.
This commit is contained in:
Joey Hess 2024-08-08 14:43:53 -04:00
parent b23c7f769e
commit 5c36177e58
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 4 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Remote/Git.hs
View file

@ -229,7 +229,8 @@ gen r u rc gc rs
, gitconfig = gc
, readonly = Git.repoIsHttp r && not (isP2PHttp' gc)
, appendonly = False
, untrustworthy = False
, untrustworthy = isJust (remoteAnnexProxiedBy gc)
&& exportTree c
, availability = repoAvail r
, remotetype = remote
, mkUnavailable = unavailable r u rc gc rs

19
doc/todo/git-annex_proxies.mdwn
View file

@ -33,23 +33,8 @@ Planned schedule of work:
* Working on `exportreeplus` branch which is groundwork for proxying to
exporttree=yes special remotes. Need to merge it to master.
* A proxied exporttree=yes special remote is not untrusted, and should be.
This needs Remote.untrustworthy to be set when constucting a proxied
Remote that uses exporttree=yes. So will need to load the remote config
to see if it does.
But, the proxy.log uses the UUID of a remote. There could be multiple
special remotes that share a UUID. Which config to load? Maybe load the
configs of them all and check if any has exporttree=yes.
Probably all ought to if any do.
Alternatively, make annexobjects=yes remotes not untrusted.
This was considered in [[todo/exporttree_remotes_could_store_any_key]],
but didn't seem very feasible.
* Also, versioned exports are not untrustworthy. But checking that would
need to construct a Remote using the special remote's config.
* Versioned exports are not untrustworthy. But checking that for a proxied
remote would need to construct a Remote using the special remote's config.
For eg S3 (the only versioned one currently), that would need the S3
creds to be set in the environment.