From 549e23188a2f817161519efb09a142503ee97250 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 4 Oct 2015 15:26:20 -0400 Subject: [PATCH] review --- ..._54bfedf6d33bcd9d44cc3c89f3216161._comment | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 doc/bugs/Utility__47__libdiskfree.c_more_BSD_friendly/comment_2_54bfedf6d33bcd9d44cc3c89f3216161._comment diff --git a/doc/bugs/Utility__47__libdiskfree.c_more_BSD_friendly/comment_2_54bfedf6d33bcd9d44cc3c89f3216161._comment b/doc/bugs/Utility__47__libdiskfree.c_more_BSD_friendly/comment_2_54bfedf6d33bcd9d44cc3c89f3216161._comment new file mode 100644 index 0000000000..b86fa05352 --- /dev/null +++ b/doc/bugs/Utility__47__libdiskfree.c_more_BSD_friendly/comment_2_54bfedf6d33bcd9d44cc3c89f3216161._comment @@ -0,0 +1,23 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2015-10-04T19:13:59Z" + content=""" +Happy to support all BSD varients that tested patches can be made for. + +I can't apply this patch as-is for several reasons: + +* You say you've not tested it yet. +* I recently modified the file to add support for Solaris, and your patch conflicts with that modification. +* Your patch in passing changes the FreeBSD support to use the + statfs64 structure. AFAIK that has not been tested. +* I think you also broke Android by moving it below the Linux tests. + The linux tests will probably fire on android, but the linux code + doesn't work with the android libc. + +Your patch would be better if it clearly added support for an OS +(or standard) without touching and breaking existing code that +supports other OSes. + +Thanks! +"""]]