mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

pre-commit: Update direct mode mappings.

Browse source 
Making the pre-commit hook look at git diff-index to find changed direct
mode files and update the mappings works pretty well.

One case where it does not work is when a file is git annex added, and then
git rmed, and then this is committed. That's a no-op commit, so the hook
probably doesn't even run, and it certianly never notices that the file
was deleted, so the mapping will still have the original filename in it.

For this and other reasons, it's important that the mappings still be
treated as possibly inconsistent.

Also, the assistant now allows the pre-commit hook to run when in direct
mode, so the mappings also get updated there.
This commit is contained in:
Joey Hess 2013-02-06 12:40:59 -04:00
parent ceb732bea7
commit 547d7745fb
8 changed files with 75 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

6
doc/bugs/direct_mode_renames.mdwn
View file

@ -8,6 +8,8 @@ file working properly in direct mode.
Perhaps the pre-commit hook needs to update the mapping for files that were
deleted or added.
(This also affects moves of files when the assistant is being used.
This also affects moves of files when the assistant is being used.
In this case, the assistant updates the mapping to add the new name,
but does not delete the old name from the mapping.)
but does not delete the old name from the mapping.
> [[done]]; the pre-commit hook now updates the mappings. --[[Joey]]