From 53ede1a10e0f80ea3ab17b3ef824004071ea069d Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 9 Jun 2015 13:28:30 -0400 Subject: [PATCH] parse X in location log file as indicating a dead key A dead key is both not present at the location that thinks it has a copy, and also is assumed to probably not be present anywhere else. Although there may be lurking disconnected repos that somehow still have a copy. Suprisingly few changes needed for this! This is because the presence log code only really concerns itself with keys that are present, and dead keys are not present. Note that both the location and web log can be parsed as having a dead key. I don't see any value to having keys listed as dead in the web log, but since it doesn't change any behavior, there was no point in not parsing it. --- Logs/Presence/Pure.hs | 4 +++- doc/internals.mdwn | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Logs/Presence/Pure.hs b/Logs/Presence/Pure.hs index ec4415aadf..b1fc212fd4 100644 --- a/Logs/Presence/Pure.hs +++ b/Logs/Presence/Pure.hs @@ -20,7 +20,7 @@ data LogLine = LogLine { info :: String } deriving (Eq, Show) -data LogStatus = InfoPresent | InfoMissing +data LogStatus = InfoPresent | InfoMissing | InfoDead deriving (Eq, Show, Bounded, Enum) {- Parses a log file. Unparseable lines are ignored. -} @@ -38,6 +38,7 @@ parseLog = mapMaybe parseline . lines parseStatus :: String -> Maybe LogStatus parseStatus "1" = Just InfoPresent parseStatus "0" = Just InfoMissing +parseStatus "X" = Just InfoDead parseStatus _ = Nothing {- Generates a log file. -} @@ -47,6 +48,7 @@ showLog = unlines . map genline genline (LogLine d s i) = unwords [show d, genstatus s, i] genstatus InfoPresent = "1" genstatus InfoMissing = "0" + genstatus InfoDead = "X" {- Given a log, returns only the info that is are still in effect. -} getLog :: String -> [String] diff --git a/doc/internals.mdwn b/doc/internals.mdwn index 7e8f4b19a0..c6dcb9621e 100644 --- a/doc/internals.mdwn +++ b/doc/internals.mdwn @@ -171,8 +171,8 @@ for file contents. These are placed in two levels of subdirectories for hashing. See [[hashing]] for details. The name of the key is the filename, and the content -consists of a timestamp, either 1 (present) or 0 (not present), and -the UUID of the repository that has or lacks the file content. +consists of a timestamp, either 1 (present) or 0 (not present) or X (dead), +and the UUID of the repository that has or lacks the file content. Example: