mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Improved display of errors when accessing a git http remote fails.

Browse source 
New error message:

  Remote foo not usable by git-annex; setting annex-ignore

  http://localhost/foo/config download failed: Configuration of annex.security.allowed-ip-addresses does not allow accessing address ::1

If git config parse fails, or the git config file is not available at the url,
a better error message for that is also shown.

This commit was sponsored by Mark Reidenbach on Patreon.
This commit is contained in:
Joey Hess 2021-03-24 14:19:32 -04:00
parent fdf1ccbe3f
commit 537f9d9a11
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 28 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

9
doc/bugs/http_remote_on_local_network_bad_error_message.mdwn
View file

@ -7,3 +7,12 @@ There needs to be a better error message, or possibly don't apply
annex.security.allowed-ip-addresses to uuid discovery -- which does not
seem like it would involve the kind of security problem that config exists
to prevent. --[[Joey]]
> While I think it would be safe to bypass
> annex.security.allowed-ip-addresses in this case, it seemed complicated
> to implement that, and also getting that wrong would be a security hole.
> Since this is a pretty unusual case, I think it's ok to need that to be
> set.
>
> So, I've improved the error message in this case. (And a few other
> cases.) [[done]] --[[Joey]]