mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Windows: Improve handling of shebang in external special remote program, searching for the program in the PATH.

Browse source 
findShellCommand needs a full path to a file in order to check it for a
shebang on Windows. It was being run with only the base name of the external
special remote program, which would only work when it was in the current
directory.

This is why users in
https://github.com/DanielDent/git-annex-remote-rclone/pull/10 and elsewhere
were complaining that the previous improvements to git-annex didn't make
git-remote-rclone work on Windows.

Also, reworked checkearlytermination, which while it worked, seemed
to rely on a race condition. And, improved its error messages.

This commit was sponsored by Shane-o on Patreon.
This commit is contained in:
Joey Hess 2017-03-08 15:56:55 -04:00
parent 0d1a1838c5
commit 5358fb992a
No known key found for this signature in database
GPG key ID: C910D9222512E3C7
5 changed files with 28 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/Failing_to_execute_bash_remotes_windows.mdwn
View file

@ -54,3 +54,5 @@ VERSION 1
### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
Oh yeah! This software is awesome. After getting used to having "dummy" shortcuts to content I don't currently have, with the simple ability to get/drop that content, I can't believe I haven't seen this anywhere before. If there is anything more impressive than this software, it's the support it has had from Joey over all this time. I'd have pulled my hair out long ago. :P
> [[fixed|done]] although untested --[[Joey]]

14
doc/bugs/Failing_to_execute_bash_remotes_windows/comment_3_691fe409f869c46e3716924e958f431a._comment Normal file
View file

@ -0,0 +1,14 @@
[[!comment format=mdwn
username="joey"
subject="""comment 3"""
date="2017-03-08T19:36:57Z"
content="""
Looking into it a bit more, the problem seems to be that findShellCommand
expects a path to a file to examine, but when it's used for an external
special remote, it's only given the name of the command.
So, I fixed it by searching for the command in the PATH.
I have still not tested if this works on Windows, but probably, I think.
As long as PATH is set on Windows at least.
"""]]