mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

testremote: Fix over-allocation of resources and bad caching

Browse source 
Including starting up a large number of external special remote processes.
(Regression introduced in version 8.20200501)
This commit is contained in:
Joey Hess 2020-06-22 14:25:49 -04:00
parent 10db6c7a41
commit 5098236c6b
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
4 changed files with 81 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

23
doc/bugs/testremote_breeds_way_too_many_instances_of_the_externals_remote/comment_1_6c4afa18ad31f46ff8c0b827415373e4._comment Normal file
View file

@ -0,0 +1,23 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2020-06-22T16:24:53Z"
content="""
There should be 4-8, because it does make that many remote
variants, each with a different config.
But, each individual test case is starting a process.
This is a reversion from around [[!commit 9fa940569c7941ad794637017ae5296e657c7f8d]].
To make git-annex test be able to use testremote, that deferred generating
Remote objects to inside the TestTree.. So it generates them when running
each test case.
Other remotes that allocate other resources will also allocate too many,
not cache http connections in testremote, etc.
The test suite was also affected in its use of testremote, but only
tested a directory special remote so I think avoided any bad behavior.
Fixed.
"""]]