improve url download failure display
* When downloading urls fail, explain which urls failed for which reasons. * web: Avoid displaying a warning when downloading one url failed but another url later succeeded. Some other uses of downloadUrl use urls that are effectively internal use, and should not all be displayed to the user on failure. Eg, Remote.Git tries different urls where content could be located depending on how the remote repo is set up. Exposing those urls to the user would lead to wild goose chases. So had to parameterize it to control whether it displays urls or not. A side effect of this change is that when there are some youtube urls and some regular urls, it will try regular urls first, even if the youtube urls are listed first. This seems like an improvement if anything, but in any case there's no defined order of urls that it's supposed to use. Sponsored-by: Dartmouth College's Datalad project
This commit is contained in:
parent
9cd1430fd6
commit
4f42292b13
8 changed files with 61 additions and 32 deletions
|
@ -41,3 +41,15 @@ refs in DataLad issues:
|
|||
|
||||
- from web remote: ["download failed: Not Found"](https://github.com/datalad/datalad/pull/5936)
|
||||
- from ["failed to retrieve content from remote"](https://github.com/datalad/datalad/issues/5750)
|
||||
|
||||
> I think this is specific to downloading urls, although it can happen
|
||||
> for a few remotes (web, external). There's really no reason to display
|
||||
> a download failed message if it successfully downloads a later url.
|
||||
> (After all, if it had tried the working url first, it would never display
|
||||
> anything about the broken url.)
|
||||
>
|
||||
> When all urls fail, it makes sense to display each url and why it failed
|
||||
> when using the web (or external) remote, so the user can decide what to
|
||||
> do about each of the problems.
|
||||
>
|
||||
> [[done]] --[[Joey]]
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue