mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fsck: Work around bug in persistent that broke display of problematically encoded filenames on stderr when using --incremental.

Browse source
This commit is contained in:
Joey Hess 2015-09-09 17:02:00 -04:00
parent 1fcca1b43b
commit 4ed82e5328
5 changed files with 36 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/hPutChar_error_message_with_UTF-8_chars_above_7F_in_filenames.mdwn
View file

@ -76,3 +76,5 @@ git-annex: fsck: 2 failed
# End of transcript or log.
"""]]
> [[fixed|done]] --[[Joey]]

20
doc/bugs/hPutChar_error_message_with_UTF-8_chars_above_7F_in_filenames/comment_1_bb9cd3e753431b1f5dd8b94a1be4e4a3._comment Normal file
View file

@ -0,0 +1,20 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2015-09-09T20:14:01Z"
content="""
It only fails with --incremental, and the only difference
is that the fsck database is opened and written that way.
Somehow, opening the database causes the encoding of the stderr handle to get
reset from the fileEncoding git-annex normally applies at startup to
the defaut, which crashes on filenames that don't use the locale's
encoding.
What a strange side effect especially to find in haskell code!
It's some kind of bug in persistent that this happens.
I've filed a bug: <https://github.com/yesodweb/persistent/issues/474>
I put in a workaround; I have it reset the encoding of the file handles
after opening the db.
"""]]