mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix test suite failure on Windows

Browse source 
It would be better if the Arbitrary instance avoided generating impossible
filenames like "foo/c:bar", but proably this is the only place that splits
the file from the directory and then uses the file without the directory..
At least on the quickcheck properties.

Sponsored-by: Svenne Krap on Patreon
This commit is contained in:
Joey Hess 2021-08-24 14:03:29 -04:00
parent f9b92c81f6
commit 4ed36b2634
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
4 changed files with 38 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/test_prop__95__view__95__roundtrips_fails_occasionally.mdwn
View file

@ -96,3 +96,5 @@ Windows version 21H1 (build 19043.1165), 64 bit.
### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
Git Annex is great. It works with multi-gigabyte backup files (largest around 180GB) via the BLAKE2B160E backend just dandy :)
> [[fixed|done]] --[[Joey]]

27
doc/bugs/test_prop__95__view__95__roundtrips_fails_occasionally/comment_1_1cac754c9fc86da7a7cb11db0c776190._comment Normal file
View file

@ -0,0 +1,27 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2021-08-24T17:01:01Z"
content="""
I fixed the other, similar bug shortly after you filed it. Please do file
bug reports for intermittent test suite breakage like this.
This does not reproduce on linux with --quickcheck-replay=258328, it's
windows specific. I can reproduce it by subbing in the windows filepath
modules on linux.
Simplified:
ghci> let f = AssociatedFile (Just "foo\\X:l")
ghci> let m = MetaData (fromList [(MetaField "H",S.fromList [MetaValue (CurrentlySet True) ">"]),(MetaField "HJ",S.fromList [MetaValue (CurrentlySet True) "a"]),(MetaField "m",S.fromList [MetaValue (CurrentlySet True) "#"]),(MetaField "ub",S.fromList [MetaValue (CurrentlySet True) "9"])])
ghci> prop_view_roundtrips f m True
False
Looks like viewedFileFromReference of that filename produces "X:l_%\\\\%",
which won't work because that looks like a drive letter.
This can't occur in real life, because "X:l" can't be the name of a file
in a directory "foo".
Fixed.
"""]]