mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

turns out this was fixed in 2014

Browse source
This commit is contained in:
Joey Hess 2020-10-22 19:54:26 -04:00
parent 2f96e15eda
commit 4d063f12c6
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Remote/Helper/Chunked.hs
View file

@ -120,6 +120,10 @@ storeChunks
-> Annex () -> Annex ()
storeChunks u chunkconfig encryptor k f p storer checker = storeChunks u chunkconfig encryptor k f p storer checker =
case chunkconfig of case chunkconfig of
-- Only stable keys are safe to store chunked,
-- because an unstable key can have multiple different
-- objects, and mixing up chunks from them would be
-- possible without this check.
(UnpaddedChunks chunksize) -> ifM (isStableKey k) (UnpaddedChunks chunksize) -> ifM (isStableKey k)
( do ( do
h <- liftIO $ openBinaryFile f ReadMode h <- liftIO $ openBinaryFile f ReadMode

7
doc/bugs/possible_data_loss_when_unsized_key_stored_chunked.mdwn
View file

@ -39,3 +39,10 @@ since it can fail so badly with them, and they're kind of a side thing?
(Could continue retrieving, for whatever is stored hopefully w/o being (Could continue retrieving, for whatever is stored hopefully w/o being
corrupted already.) corrupted already.)
--[[Joey]] --[[Joey]]
> This would also affect any key that is not stable.
> And oh, it stopped using chunks to store non-stable keys in 2014.
>
> So, this can't really happen with url keys, because they're not stable.
> Ok, not a bug then, because if the key is stable, there can only be one
> object for it, by definition. Whew! [[done]] --[[Joey]]