mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

add docs about p2p --pair being broken in old versions

Browse source
This commit is contained in:
Joey Hess 2018-07-05 11:52:52 -04:00
parent f60e0df0e0
commit 49cc94f61f
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
6 changed files with 63 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/apparent_regression_in_git_annex_p2p_--pair_usage_of_magic_wormhole_invocation.mdwn
View file

@ -70,3 +70,5 @@ Yes, but not `p2p --pair`.
`p2p --link` works, including syncing, no problems with the remote daemon itself.
... and I wouldn't call it luck, i both trust and rely on git annex =)
> [[fixed|done]]

22
doc/bugs/apparent_regression_in_git_annex_p2p_--pair_usage_of_magic_wormhole_invocation/comment_1_d403b087693d766b8f902c27964268e2._comment Normal file
View file

@ -0,0 +1,22 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2018-07-05T15:28:15Z"
content="""
Thanks much for reporting this bug. It turns out that shortly after I
first implemented this, magic-wormhole switched to outputting that text on
stderr, which defeated git-annex's attempt to extract the code phrase.
[[!commit 3dd7f450c1968f8bc2b9cc73c701b1f12f7e326a]] fixes the bug.
Really unfortunate this feature has been broken since almost the beginning.
Especially because pairing with a friend will fail if they have an older
version of git-annex. Added a note about this to the documentation.
Clearly some better testing of this is needed. Testing network stuff like
this is outside the bounds of git-annex's usual test suite, and perhaps it
needs an additional test suite that is allowed to make network connections.
(testremote is allowed to, but needs the remote to be manually set up,
so this is also outside its scope). Opened [[todo/network_test_suite]]
about this.
"""]]