Fix shell escaping in rsync special remote.
This commit is contained in:
parent
50edbb03eb
commit
45bbf210a1
3 changed files with 14 additions and 4 deletions
|
@ -93,10 +93,13 @@ rsyncSetup u c = do
|
|||
return c'
|
||||
|
||||
rsyncKey :: RsyncOpts -> Key -> String
|
||||
rsyncKey o k = rsyncUrl o </> hashDirMixed k </> f </> f
|
||||
rsyncKey o k = rsyncUrl o </> hashDirMixed k </> shellEscape (f </> f)
|
||||
where
|
||||
f = keyFile k
|
||||
|
||||
rsyncKeyDir :: RsyncOpts -> Key -> String
|
||||
rsyncKeyDir o k = rsyncUrl o </> hashDirMixed k </> shellEscape (keyFile k)
|
||||
|
||||
store :: RsyncOpts -> Key -> Annex Bool
|
||||
store o k = do
|
||||
g <- Annex.gitRepo
|
||||
|
@ -136,7 +139,7 @@ remove o k = withRsyncScratchDir $ \tmp -> do
|
|||
[ Params "--delete --recursive"
|
||||
, partialParams
|
||||
, Param $ addTrailingPathSeparator dummy
|
||||
, Param $ parentDir $ rsyncKey o k
|
||||
, Param $ rsyncKeyDir o k
|
||||
]
|
||||
|
||||
checkPresent :: Git.Repo -> RsyncOpts -> Key -> Annex (Either IOException Bool)
|
||||
|
@ -147,8 +150,7 @@ checkPresent r o k = do
|
|||
res <- liftIO $ boolSystem "sh" [Param "-c", Param cmd]
|
||||
return $ Right res
|
||||
where
|
||||
cmd = "rsync --quiet " ++ testfile ++ " 2>/dev/null"
|
||||
testfile = shellEscape $ rsyncKey o k
|
||||
cmd = "rsync --quiet " ++ shellEscape (rsyncKey o k) ++ " 2>/dev/null"
|
||||
|
||||
{- Rsync params to enable resumes of sending files safely,
|
||||
- ensure that files are only moved into place once complete
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue