mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

migrate: Fix failure to migrate from URL keys. (Reversion introduced in version 6.20180926)

Browse source
This commit is contained in:
Joey Hess 2018-10-29 16:26:43 -04:00
parent d73f92d8bc
commit 4431b82bce
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 63 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

19
doc/todo/do_not_allow_using_stop_in_CommandPerform.mdwn Normal file
View file

@ -0,0 +1,19 @@
`stop` does different things depending on the stage of a command that it's
used in.
In CommandStart, it quietly stops any further action.
In CommandPerform, it causes the command to fail,
which looks like "commandname actionitem failed".
If no other output is emitted to say why it failed,
this is not nice.
(It can't be used in CommandCleanup.)
It would be good to get rid of support for running `stop` in
CommandPerform. Simply change the type:
- stop :: Annex (Maybe a)
+ stop :: CommandStart
And follow the compile errors.