mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

migrate: Fix failure to migrate from URL keys. (Reversion introduced in version 6.20180926)

Browse source
This commit is contained in:
Joey Hess 2018-10-29 16:26:43 -04:00
parent d73f92d8bc
commit 4431b82bce
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 63 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/git-annex-migrate_fails.mdwn
View file

@ -24,3 +24,5 @@ Migrating from a URL key to an MD5E key (after addurl --fast using an external s
[2018-10-29 15:17:15.621264] read: git ["--git-dir=.git","--work-tree=.","--literal-pathspecs","ls-files","--cached","-z","--","A4.taxfilt.bam"]
migrate A4.taxfilt.bam failed
git-annex: migrate: 1 failed
> [[fixed|done]] --[[Joey]]

27
doc/bugs/git-annex-migrate_fails/comment_1_4f8fb57ce001e0a2e1636bd7b3b79d43._comment Normal file
View file

@ -0,0 +1,27 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2018-10-29T20:04:48Z"
content="""
To reproduce this bug:
joey@darkstar:/tmp/t>git annex addurl --fast --raw http://www.google.com/ --file A4.taxfilt.bam
addurl http://www.google.com/ (to A4.taxfilt.bam) ok
(recording state in git...)
joey@darkstar:/tmp/t>git annex get A4.taxfilt.bam
get A4.taxfilt.bam (from web...)
ok
(recording state in git...)
joey@darkstar:/tmp/t>git annex migrate --backend=MD5E A4.taxfilt.bam
migrate A4.taxfilt.bam failed
git-annex: migrate: 1 failed
Seems to be a bug in handling backends with fastMigrate = Nothing, causing
it to stop immediately without doing anything. Reversion introduced in
[[!commit 4ecba916a14e02dd62f8ba4257db810fa859f017]].
And calling `stop` in a CommandPerform causes this failure without an
explanation. I think that would be worth cleaning up at some point;
[[todo/do_not_allow_using_stop_in_CommandPerform]].
"""]]