From 4144f73c186bbd7d2ff07af59b55118d458899c6 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 24 Feb 2022 13:10:40 -0400 Subject: [PATCH] comment --- .../comment_3_223df2a9cebd99a312537137863b1781._comment | 7 ++++++- .../comment_4_c78b91393ca917f9d231c39702c70e14._comment | 9 +++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 doc/bugs/can__39__t_make_annex_happy_in_freeze__47__thaw/comment_4_c78b91393ca917f9d231c39702c70e14._comment diff --git a/doc/bugs/can__39__t_make_annex_happy_in_freeze__47__thaw/comment_3_223df2a9cebd99a312537137863b1781._comment b/doc/bugs/can__39__t_make_annex_happy_in_freeze__47__thaw/comment_3_223df2a9cebd99a312537137863b1781._comment index 6c16581c19..e7d69b6dc7 100644 --- a/doc/bugs/can__39__t_make_annex_happy_in_freeze__47__thaw/comment_3_223df2a9cebd99a312537137863b1781._comment +++ b/doc/bugs/can__39__t_make_annex_happy_in_freeze__47__thaw/comment_3_223df2a9cebd99a312537137863b1781._comment @@ -9,6 +9,11 @@ hook or no freeze hook), it still checks if the file's write permissions got removed. I think that, in order to support filesystems where chmod -w has no effect, -init should skip looking at perms when there is a freeze hook. It can +init should skip looking at write perms when there is a freeze hook. It can still check that freezing prevents writing to a file. + +Hmm, init uses checkContentWritePerm to see if the write permission is +removed. That is also used by fsck, and when ingesting a file. So even if +it were fixed in init, those would still be problems. This really needs to +be fixed in checkContentWritePerm. """]] diff --git a/doc/bugs/can__39__t_make_annex_happy_in_freeze__47__thaw/comment_4_c78b91393ca917f9d231c39702c70e14._comment b/doc/bugs/can__39__t_make_annex_happy_in_freeze__47__thaw/comment_4_c78b91393ca917f9d231c39702c70e14._comment new file mode 100644 index 0000000000..0e97320c48 --- /dev/null +++ b/doc/bugs/can__39__t_make_annex_happy_in_freeze__47__thaw/comment_4_c78b91393ca917f9d231c39702c70e14._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 4""" + date="2022-02-24T17:07:19Z" + content=""" +I think that this issue with drop freezing the content needs to be treated +as a separate bug. There also may be a good reason for it to do it, I have +not looked into that yet. +"""]]