diff --git a/doc/bugs/git_annex_config_annex.securehashesonly_fails.mdwn b/doc/bugs/git_annex_config_annex.securehashesonly_fails.mdwn new file mode 100644 index 0000000000..1c4db1e52b --- /dev/null +++ b/doc/bugs/git_annex_config_annex.securehashesonly_fails.mdwn @@ -0,0 +1,33 @@ +From [git-annex-config](https://git-annex.branchable.com/git-annex-config/): + +> annex.securehashesonly +> +> Set to true to indicate that the repository should only use cryptographically secure hashes (SHA2, SHA3) and not insecure hashes (MD5, SHA1) for content. + +From my computer: + +``` +$ git annex config --set annex.securehashesonly true +git-annex: annex.securehashesonly is not a configuration setting that can be stored in the git-annex branch +``` + +So either the documentation is incorrect, or something isn't working right. + +macOS 10.15.7 + +``` +$ git annex version +git-annex version: 8.20210310 +build flags: Assistant Webapp Pairing FsEvents TorrentParser MagicMime Feeds Testsuite S3 WebDAV +dependency versions: aws-0.22 bloomfilter-2.0.1.0 cryptonite-0.28 DAV-1.3.4 feed-1.3.0.1 ghc-8.10.4 http-client-0.7.6 persistent-sqlite-2.11.1.0 torrent-10000.1.1 uuid-1.3.14 yesod-1.6.1.0 +key/value backends: SHA256E SHA256 SHA512E SHA512 SHA224E SHA224 SHA384E SHA384 SHA3_256E SHA3_256 SHA3_512E SHA3_512 SHA3_224E SHA3_224 SHA3_384E SHA3_384 SKEIN256E SKEIN256 SKEIN512E SKEIN512 BLAKE2B256E BLAKE2B256 BLAKE2B512E BLAKE2B512 BLAKE2B160E BLAKE2B160 BLAKE2B224E BLAKE2B224 BLAKE2B384E BLAKE2B384 BLAKE2BP512E BLAKE2BP512 BLAKE2S256E BLAKE2S256 BLAKE2S160E BLAKE2S160 BLAKE2S224E BLAKE2S224 BLAKE2SP256E BLAKE2SP256 BLAKE2SP224E BLAKE2SP224 SHA1E SHA1 MD5E MD5 WORM URL X* +remote types: git gcrypt p2p S3 bup directory rsync web bittorrent webdav adb tahoe glacier ddar git-lfs httpalso borg hook external +operating system: darwin x86_64 +supported repository versions: 8 +upgrade supported from repository versions: 0 1 2 3 4 5 6 7 +local repository version: 8 +``` + +### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders) + +it's great! diff --git a/doc/bugs/indeterminite_preferred_content_state_for_duplicated_file/comment_6_d708d3140ad651ea8ca084d483977d3d._comment b/doc/bugs/indeterminite_preferred_content_state_for_duplicated_file/comment_6_d708d3140ad651ea8ca084d483977d3d._comment deleted file mode 100644 index 92993d6605..0000000000 --- a/doc/bugs/indeterminite_preferred_content_state_for_duplicated_file/comment_6_d708d3140ad651ea8ca084d483977d3d._comment +++ /dev/null @@ -1,8 +0,0 @@ -[[!comment format=mdwn - username="Ilya_Shlyakhter" - avatar="http://cdn.libravatar.org/avatar/1647044369aa7747829c38b9dcc84df0" - subject="comment 6" - date="2021-04-17T22:54:44Z" - content=""" -P.S. There might be some more uses for a keys-to-paths db. E.g. when operating on all keys, [[git-annex-matching-options]] could support matching by filename. When storing to a (non-exporttree) remote, path could be given as a hint to use for the storage path. -"""]] diff --git a/doc/bugs/indeterminite_preferred_content_state_for_duplicated_file/comment_7_5f1ee7b0899a1770fb5849d7476ec335._comment b/doc/bugs/indeterminite_preferred_content_state_for_duplicated_file/comment_7_5f1ee7b0899a1770fb5849d7476ec335._comment new file mode 100644 index 0000000000..38c80cce9d --- /dev/null +++ b/doc/bugs/indeterminite_preferred_content_state_for_duplicated_file/comment_7_5f1ee7b0899a1770fb5849d7476ec335._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="Ilya_Shlyakhter" + avatar="http://cdn.libravatar.org/avatar/1647044369aa7747829c38b9dcc84df0" + subject="semantics of preferred content expressions" + date="2021-04-18T22:03:02Z" + content=""" +It seems the underlying issue is that preferred content expressions are defined as predicates on *files*, but then used to determine preferred state of *keys*. The name \"preferred *content*\" suggests they're predicates on *keys*. The set of paths that use a key is a property of a key, like a special metadata field `_path`. Suppose `includeifany=glob` was true for a key if *any* value in `_path` matched `glob`, while `includeifall=glob` was true if *all* values in `_path` did. Treat `include=glob` as `includeifany=glob` and `exclude=glob` as `not includeifall=glob`. Then `include=* and exclude=archive/*` unambiguously means \"include all keys except those used only under `archive/`\". (This has the problem that `include=glob` is not the same as `not exclude=glob`. But the meaning seems to match the typical current usage of `include` and `exclude`?) + +"""]] diff --git a/doc/bugs/indeterminite_preferred_content_state_for_duplicated_file/comment_7_fe9d7c70172fd104797b094b720aee18._comment b/doc/bugs/indeterminite_preferred_content_state_for_duplicated_file/comment_7_fe9d7c70172fd104797b094b720aee18._comment new file mode 100644 index 0000000000..ddf4c68076 --- /dev/null +++ b/doc/bugs/indeterminite_preferred_content_state_for_duplicated_file/comment_7_fe9d7c70172fd104797b094b720aee18._comment @@ -0,0 +1,8 @@ +[[!comment format=mdwn + username="Ilya_Shlyakhter" + avatar="http://cdn.libravatar.org/avatar/1647044369aa7747829c38b9dcc84df0" + subject="comment 7" + date="2021-04-19T15:38:37Z" + content=""" +I guess, simplest to just say that preferred content expressions are predicates on files (as now), and a key is preferred if any file using the key is preferred. Maybe clarify that in the docs? +"""]] diff --git a/doc/bugs/poor_choice_of_name_for_adjusted_branches.mdwn b/doc/bugs/poor_choice_of_name_for_adjusted_branches.mdwn new file mode 100644 index 0000000000..17a3ac14f6 --- /dev/null +++ b/doc/bugs/poor_choice_of_name_for_adjusted_branches.mdwn @@ -0,0 +1,24 @@ +### Please describe the problem. + +The naming conventions for adjusted branches are poorly chosen (adjusted/master(unlocked) or adjusted/master(hidemissing)). The parentheses cause problems when checking out the branch without protecting the name by way of quotation marks. This problem is exacarbated at least on my Ubuntu Focal system by the fact that the provided bash-completion completes the branch name without those marks. + +### What version of git-annex are you using? On what operating system? +8.20200226-1 on Ubuntu Focal + +### What steps will reproduce the problem? + + git annex adjust --hide-missing + git checkout master + #git checkout adjTABusted/master(hidemissing) + git checkout adjusted/master(hidemissing) + +Result: + + $ git checkout adjusted/master(hidemissing) + bash: syntax error near unexpected token `(' + $ git checkout "adjusted/master(hidemissing)" + Switched to branch 'adjusted/master(hidemissing)' + +The problem is easy to fix, I think, by choosing a different naming convention. I'm not sure how to deal with legacy-named branches going forward, though. + +Thank you very much for making git-annex available, much appreciated. diff --git a/doc/bugs/tests_fail_on_windows__58___retrieveKeyFile_resume.mdwn b/doc/bugs/tests_fail_on_windows__58___retrieveKeyFile_resume.mdwn new file mode 100644 index 0000000000..a55abbd983 --- /dev/null +++ b/doc/bugs/tests_fail_on_windows__58___retrieveKeyFile_resume.mdwn @@ -0,0 +1,23 @@ +### Please describe the problem. + + +``` + retrieveKeyFile: FAIL + Exception: .git\annex\objects\fc0\296\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key: DeleteFile "\\\\?\\C:\\Users\\runneradmin\\.t\\main2\\.git\\annex\\objects\\fc0\\296\\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key\\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key": permission denied (Access is denied.) + fsck downloaded object: OK (0.01s) + retrieveKeyFile resume from 33%: FAIL + Exception: .git\annex\tmp\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key: openBinaryFile: permission denied (Permission denied) + fsck downloaded object: OK (0.01s) + retrieveKeyFile resume from 0: FAIL + Exception: .git\annex\tmp\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key: openFile: permission denied (Permission denied) + fsck downloaded object: OK (0.01s) +cp: cannot create regular file '.git\annex\tmp\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key': Permission denied + retrieveKeyFile resume from end: FAIL + Exception: .git\annex\objects\fc0\296\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key: DeleteFile "\\\\?\\C:\\Users\\runneradmin\\.t\\main2\\.git\\annex\\objects\\fc0\\296\\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key\\SHA256E-s1048576--c347f274df214671e3bebb6674cc5d2e6c226d8358a416859d5fc3c79a08eb1f.this-is-a-test-key": permission denied (Access is denied.) + fsck downloaded object: OK (0.01s) + removeKey when present: OK (0.09s) +``` + +I think this fail is relatively recent since [5 days ago](https://github.com/datalad/git-annex/actions/runs/746941168) is green for git-annex (but red for datalad). Overall [today's log](https://github.com/datalad/git-annex/runs/2377452030?check_suite_focus=true) for 8.20210331-ge3de27dcc says `126 out of 833 tests failed (599.24s)` + +not sure if relates to [ubuntu build fails](https://git-annex.branchable.com/bugs/fresh_3_tests_fails-_openBinaryFile__58___resource_busy/) which seems to be less wild, so filing separately diff --git a/doc/todo/option_to___96__drop_path__96___to_not_drop___34__all_copies__34__/comment_3_2665f3fc268dff1de24d6ee9648c5d8c._comment b/doc/todo/option_to___96__drop_path__96___to_not_drop___34__all_copies__34__/comment_3_2665f3fc268dff1de24d6ee9648c5d8c._comment new file mode 100644 index 0000000000..b4fc1a93df --- /dev/null +++ b/doc/todo/option_to___96__drop_path__96___to_not_drop___34__all_copies__34__/comment_3_2665f3fc268dff1de24d6ee9648c5d8c._comment @@ -0,0 +1,8 @@ +[[!comment format=mdwn + username="Ilya_Shlyakhter" + avatar="http://cdn.libravatar.org/avatar/1647044369aa7747829c38b9dcc84df0" + subject="comment 3" + date="2021-04-18T23:45:25Z" + content=""" +As a more general solution, suppose [[git-annex-matching-options]] were extended with the expressions `—includeifany=glob` (true for a key if *any* file using that key matches `glob`), `—includeifall=glob` (true for a key if *all* files using that key match `glob`), and similarly `—excludeifany/all`. Then use `drop —includeifall=path/*`. +"""]]