attempt at a quick, utf-8 only fix to the ghc 7.4 problem

If you have only utf-8 filenames, and need to build git-annex with ghc 7.4,
this will work. But, it will crash on non-utf-8 filenames.
This commit is contained in:
Joey Hess 2012-02-01 16:05:02 -04:00
parent 6c64a214fa
commit 3d49258e5b
9 changed files with 36 additions and 29 deletions

View file

@ -7,7 +7,7 @@
module Command.Uninit where module Command.Uninit where
import qualified Data.ByteString.Lazy.Char8 as B import qualified Data.Text.Lazy as L
import Common.Annex import Common.Annex
import Command import Command
@ -29,7 +29,7 @@ check = do
when (b == Annex.Branch.name) $ error $ when (b == Annex.Branch.name) $ error $
"cannot uninit when the " ++ show b ++ " branch is checked out" "cannot uninit when the " ++ show b ++ " branch is checked out"
where where
current_branch = Git.Ref . Prelude.head . lines . B.unpack <$> revhead current_branch = Git.Ref . Prelude.head . lines . L.unpack <$> revhead
revhead = inRepo $ Git.Command.pipeRead revhead = inRepo $ Git.Command.pipeRead
[Params "rev-parse --abbrev-ref HEAD"] [Params "rev-parse --abbrev-ref HEAD"]

View file

@ -10,7 +10,8 @@
module Command.Unused where module Command.Unused where
import qualified Data.Set as S import qualified Data.Set as S
import qualified Data.ByteString.Lazy.Char8 as L import qualified Data.Text.Lazy as L
import qualified Data.Text.Lazy.Encoding as L
import Common.Annex import Common.Annex
import Command import Command
@ -202,7 +203,7 @@ getKeysReferencedInGit ref = do
findkeys c [] = return c findkeys c [] = return c
findkeys c (l:ls) findkeys c (l:ls)
| isSymLink (LsTree.mode l) = do | isSymLink (LsTree.mode l) = do
content <- catFile ref $ LsTree.file l content <- L.decodeUtf8 <$> catFile ref (LsTree.file l)
case fileKey (takeFileName $ L.unpack content) of case fileKey (takeFileName $ L.unpack content) of
Nothing -> findkeys c ls Nothing -> findkeys c ls
Just k -> findkeys (k:c) ls Just k -> findkeys (k:c) ls

View file

@ -7,7 +7,7 @@
module Git.Branch where module Git.Branch where
import qualified Data.ByteString.Lazy.Char8 as L import qualified Data.Text.Lazy as L
import Common import Common
import Git import Git

View file

@ -7,7 +7,10 @@
module Git.Command where module Git.Command where
import qualified Data.ByteString.Lazy.Char8 as L import qualified Data.Text.Lazy as L
import qualified Data.Text.Lazy.Encoding as L
import qualified Data.Text.Lazy.IO as L
import qualified Data.ByteString.Lazy as B
import Common import Common
import Git import Git
@ -38,28 +41,27 @@ run subcommand params repo = assertLocal repo $
- Note that this leaves the git process running, and so zombies will - Note that this leaves the git process running, and so zombies will
- result unless reap is called. - result unless reap is called.
-} -}
pipeRead :: [CommandParam] -> Repo -> IO L.ByteString pipeRead :: [CommandParam] -> Repo -> IO L.Text
pipeRead params repo = assertLocal repo $ do pipeRead params repo = assertLocal repo $ do
(_, h) <- hPipeFrom "git" $ toCommand $ gitCommandLine params repo (_, h) <- hPipeFrom "git" $ toCommand $ gitCommandLine params repo
hSetBinaryMode h True L.decodeUtf8 <$> B.hGetContents h
L.hGetContents h
{- Runs a git subcommand, feeding it input. {- Runs a git subcommand, feeding it input.
- You should call either getProcessStatus or forceSuccess on the PipeHandle. -} - You should call either getProcessStatus or forceSuccess on the PipeHandle. -}
pipeWrite :: [CommandParam] -> L.ByteString -> Repo -> IO PipeHandle pipeWrite :: [CommandParam] -> L.Text -> Repo -> IO PipeHandle
pipeWrite params s repo = assertLocal repo $ do pipeWrite params s repo = assertLocal repo $ do
(p, h) <- hPipeTo "git" (toCommand $ gitCommandLine params repo) (p, h) <- hPipeTo "git" (toCommand $ gitCommandLine params repo)
L.hPut h s L.hPutStr h s
hClose h hClose h
return p return p
{- Runs a git subcommand, feeding it input, and returning its output. {- Runs a git subcommand, feeding it input, and returning its output.
- You should call either getProcessStatus or forceSuccess on the PipeHandle. -} - You should call either getProcessStatus or forceSuccess on the PipeHandle. -}
pipeWriteRead :: [CommandParam] -> L.ByteString -> Repo -> IO (PipeHandle, L.ByteString) pipeWriteRead :: [CommandParam] -> L.Text -> Repo -> IO (PipeHandle, L.Text)
pipeWriteRead params s repo = assertLocal repo $ do pipeWriteRead params s repo = assertLocal repo $ do
(p, from, to) <- hPipeBoth "git" (toCommand $ gitCommandLine params repo) (p, from, to) <- hPipeBoth "git" (toCommand $ gitCommandLine params repo)
hSetBinaryMode from True hSetBinaryMode from True
L.hPut to s L.hPutStr to s
hClose to hClose to
c <- L.hGetContents from c <- L.hGetContents from
return (p, c) return (p, c)
@ -67,12 +69,14 @@ pipeWriteRead params s repo = assertLocal repo $ do
{- Reads null terminated output of a git command (as enabled by the -z {- Reads null terminated output of a git command (as enabled by the -z
- parameter), and splits it. -} - parameter), and splits it. -}
pipeNullSplit :: [CommandParam] -> Repo -> IO [String] pipeNullSplit :: [CommandParam] -> Repo -> IO [String]
pipeNullSplit params repo = map L.unpack <$> pipeNullSplitB params repo pipeNullSplit params repo = map L.unpack <$> pipeNullSplitT params repo
{- For when Strings are not needed. -} {- For when Strings are not needed. -}
pipeNullSplitB ::[CommandParam] -> Repo -> IO [L.ByteString] pipeNullSplitT ::[CommandParam] -> Repo -> IO [L.Text]
pipeNullSplitB params repo = filter (not . L.null) . L.split '\0' <$> pipeNullSplitT params repo = filter (not . L.null) . L.splitOn sep <$>
pipeRead params repo pipeRead params repo
where
sep = L.pack "\0"
{- Reaps any zombie git processes. -} {- Reaps any zombie git processes. -}
reap :: IO () reap :: IO ()

View file

@ -14,7 +14,7 @@ module Git.LsTree (
import Numeric import Numeric
import Control.Applicative import Control.Applicative
import System.Posix.Types import System.Posix.Types
import qualified Data.ByteString.Lazy.Char8 as L import qualified Data.Text.Lazy as L
import Common import Common
import Git import Git
@ -31,11 +31,11 @@ data TreeItem = TreeItem
{- Lists the contents of a Ref -} {- Lists the contents of a Ref -}
lsTree :: Ref -> Repo -> IO [TreeItem] lsTree :: Ref -> Repo -> IO [TreeItem]
lsTree t repo = map parseLsTree <$> lsTree t repo = map parseLsTree <$>
pipeNullSplitB [Params "ls-tree --full-tree -z -r --", File $ show t] repo pipeNullSplitT [Params "ls-tree --full-tree -z -r --", File $ show t] repo
{- Parses a line of ls-tree output. {- Parses a line of ls-tree output.
- (The --long format is not currently supported.) -} - (The --long format is not currently supported.) -}
parseLsTree :: L.ByteString -> TreeItem parseLsTree :: L.Text -> TreeItem
parseLsTree l = TreeItem parseLsTree l = TreeItem
{ mode = fst $ Prelude.head $ readOct $ L.unpack m { mode = fst $ Prelude.head $ readOct $ L.unpack m
, typeobj = L.unpack t , typeobj = L.unpack t

View file

@ -18,8 +18,9 @@ import qualified Data.Map as M
import System.IO import System.IO
import System.Cmd.Utils import System.Cmd.Utils
import Data.String.Utils import Data.String.Utils
import Utility.SafeCommand import Codec.Binary.UTF8.String
import Utility.SafeCommand
import Common import Common
import Git import Git
import Git.Command import Git.Command
@ -90,4 +91,4 @@ runAction repo action files =
where where
params = toCommand $ gitCommandLine params = toCommand $ gitCommandLine
(Param (getSubcommand action):getParams action) repo (Param (getSubcommand action):getParams action) repo
feedxargs h = hPutStr h $ join "\0" files feedxargs h = hPutStr h $ join "\0" $ map encodeString files

View file

@ -7,7 +7,7 @@
module Git.Ref where module Git.Ref where
import qualified Data.ByteString.Lazy.Char8 as L import qualified Data.Text.Lazy as L
import Common import Common
import Git import Git

View file

@ -15,7 +15,8 @@ module Git.UnionMerge (
) where ) where
import System.Cmd.Utils import System.Cmd.Utils
import qualified Data.ByteString.Lazy.Char8 as L import qualified Data.Text.Lazy as L
import qualified Data.Text.Lazy.Encoding as L
import qualified Data.Set as S import qualified Data.Set as S
import Common import Common
@ -110,11 +111,11 @@ mergeFile info file h repo = case filter (/= nullSha) [Ref asha, Ref bsha] of
calcMerge . zip shas <$> mapM getcontents shas calcMerge . zip shas <$> mapM getcontents shas
where where
[_colonmode, _bmode, asha, bsha, _status] = words info [_colonmode, _bmode, asha, bsha, _status] = words info
getcontents s = L.lines <$> catObject h s getcontents s = L.lines . L.decodeUtf8 <$> catObject h s
use sha = return $ Just $ update_index_line sha file use sha = return $ Just $ update_index_line sha file
{- Injects some content into git, returning its Sha. -} {- Injects some content into git, returning its Sha. -}
hashObject :: Repo -> L.ByteString -> IO Sha hashObject :: Repo -> L.Text -> IO Sha
hashObject repo content = getSha subcmd $ do hashObject repo content = getSha subcmd $ do
(h, s) <- pipeWriteRead (map Param params) content repo (h, s) <- pipeWriteRead (map Param params) content repo
L.length s `seq` do L.length s `seq` do
@ -130,7 +131,7 @@ hashObject repo content = getSha subcmd $ do
- When possible, reuses the content of an existing ref, rather than - When possible, reuses the content of an existing ref, rather than
- generating new content. - generating new content.
-} -}
calcMerge :: [(Ref, [L.ByteString])] -> Either Ref [L.ByteString] calcMerge :: [(Ref, [L.Text])] -> Either Ref [L.Text]
calcMerge shacontents calcMerge shacontents
| null reuseable = Right $ new | null reuseable = Right $ new
| otherwise = Left $ fst $ Prelude.head reuseable | otherwise = Left $ fst $ Prelude.head reuseable

View file

@ -128,9 +128,9 @@ showRaw s = handle q $ putStrLn s
- -
- NB: Once git-annex gets localized, this will need a rethink. -} - NB: Once git-annex gets localized, this will need a rethink. -}
setupConsole :: IO () setupConsole :: IO ()
setupConsole = do setupConsole = return ()
hSetBinaryMode stdout True --hSetBinaryMode stdout True
hSetBinaryMode stderr True --hSetBinaryMode stderr True
handle :: IO () -> IO () -> Annex () handle :: IO () -> IO () -> Annex ()
handle json normal = Annex.getState Annex.output >>= go handle json normal = Annex.getState Annex.output >>= go