mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix fileJournal

Browse source 
My ByteString rewrite oversimplified it, resulting in any _ in a journal
file turning into a / in the git-annex branch, which was often the wrong
filename, or sometimes (//) an invalid filename that git
refused to add.
This commit is contained in:
Joey Hess 2019-12-18 11:29:34 -04:00
parent 8ed171c69f
commit 3d38ec9585
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 21 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

18
doc/todo/optimize_by_converting_String_to_ByteString.mdwn
View file

@ -11,24 +11,10 @@ than find so the improvement is not as large.
The `bs` branch is in a mergeable state now, but still needs work:
* There's a bug impacting WORM keys with / in the keyname.
The files stored in the git-annex branch used to have the `/` changed
to `_`, but on the bs branch that does not happen. git also outputs
a message about "Ignoring" the file.
Test case:
git config annex.backend WORM
git annex addurl http://localhost/~joey/index.html
Hmm, that prints out the Ignoring message, and the file does not get
written to the git-annex branch. But in my big repo, I saw the message
and saw a file in the branch, with `/` in its keyname. Earlier in the
branch, the same key used `_`. (Look for "36bfe385607b32c4d5150404c0" to
find it again.)
* Profile various commands and look for hot spots.
* ByteString.Char8.putStrLn may truncate?
* Eliminate all the fromRawFilePath, toRawFilePath, encodeBS,
decodeBS conversions. Or at least most of them. There are likely
some places where a value is converted back and forth several times.