mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

addurl --preserve-filename for other remotes

Browse source 
Finishing work begun in 6952060665

Also, truncate filenames provided by other remotes if they're too long,
when --preserve-filename is not used. That seems to have been omitted
before by accident.
This commit is contained in:
Joey Hess 2020-05-11 14:32:36 -04:00
parent 5f5170b22b
commit 39d7e6dd2a
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 27 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/addurl__58___content-disposition_field_should_be_taken_as_is_without_obfuscation_.mdwn
View file

@ -45,3 +45,5 @@ git-annex version: 7.20190708+git9-gfa3524b95-1~ndall+1
[[!meta author=yoh]]
[[!tag projects/dandi]]
> [[done]] --[[Joey]]

6
doc/bugs/addurl__58___content-disposition_field_should_be_taken_as_is_without_obfuscation_/comment_5_fad1fe49c2c545aeeb388176d2f5a893._comment
View file

@ -3,10 +3,12 @@
subject="""comment 5"""
date="2020-05-11T17:20:07Z"
content="""
I agree that it may as well allow non-leading '-'.
I agree that it may as well allow non-leading '-'. But, if you are relying
on getting the unsanitized filename generally, you should use
--preserve-filename
Web browsers do do some santization, particulary of '/'.
Chrome removes leading "." as well. Often files are downloaded to locations
Chrome removes leading "." as well. Often files are downloaded
without the user confirming it. I suspect there is enough insecurity
in that area that someone could make a living injecting bitcoin miners into
dotfiles.