mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

response

Browse source
This commit is contained in:
Joey Hess 2017-10-25 15:04:55 -04:00
parent ce6c46e643
commit 38c0e09de6
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
doc/bugs/graft__47__graft_cleanup_commits_--_really_needed__63__/comment_1_7bc271ddeafc92d36d2b90fcb1481891._comment Normal file
View file

@ -0,0 +1,21 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2017-10-25T18:56:49Z"
content="""
They're really needed. Squashing them together would make the tree ref
that's being grafted in not be reachable, so it would be subject to GC,
which would lose data that the export feature needs to make sure is
retained for later.
It would be possible to squash the graft cleanup with the export.log update
commit. However, I was unable to stage the graft
into the git-annex branch index file using git update-index, due to
possibly a bug in git, so I was not able to find a way to do that.
See [[!commit 5483ea90eca33f61c799fb6a3c2675657caa9c75]]
The diff makes it look somehow big and expensive, but the actual overhead
on disk is two commit objects. The tree object being grafted in is the
exported tree, so retaining it does not really add any overhead. So
something in the area of 2 kb overhead, per export of a tree.
"""]]