mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

annex.diskreserve default increased from 1 mb to 100 mb

Browse source 
It's hard to know what's a good default for this. But 1 mb seems way too
small, because it's very easy for a git pull or some similar operation
that we don't think of as using much space to use up 1 mb of space.

Most people would want to free up some space if a filesystem only had 100
mb free. But on a small VPS, it's probably not uncommon to have only 1 gb
free. So 1 gb is too large for annex.diskreserve.

While old 1 gb USB keys are around, it's unlikely that anyone is
relying on them to shuttle annex data around; it would be worth anyone's
time to upgrade to a 32 gb or larger cheap modern USB key ($5).

Sponsored-by: Kevin Mueller on Patreon
This commit is contained in:
Joey Hess 2022-09-21 15:00:13 -04:00
parent 94216c99a7
commit 34e313f786
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
4 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG
View file

@ -1,5 +1,6 @@
git-annex (10.20220823) UNRELEASED; urgency=medium git-annex (10.20220823) UNRELEASED; urgency=medium
* annex.diskreserve default increased from 1 mb to 100 mb.
* Include the assistant and webapp when building with cabal 3.4.1.0. * Include the assistant and webapp when building with cabal 3.4.1.0.
* Merged the webapp build flag into the assistant build flag. * Merged the webapp build flag into the assistant build flag.
* Optimise linker in linux standalone tarballs. * Optimise linker in linux standalone tarballs.

2
Types/GitConfig.hs
View file

@ -153,7 +153,7 @@ extractGitConfig configsource r = GitConfig
, annexUUID = hereuuid , annexUUID = hereuuid
, annexNumCopies = configuredNumCopies , annexNumCopies = configuredNumCopies
<$> getmayberead (annexConfig "numcopies") <$> getmayberead (annexConfig "numcopies")
, annexDiskReserve = fromMaybe onemegabyte $ , annexDiskReserve = fromMaybe (onemegabyte * 100) $
readSize dataUnits =<< getmaybe (annexConfig "diskreserve") readSize dataUnits =<< getmaybe (annexConfig "diskreserve")
, annexDirect = getbool (annexConfig "direct") False , annexDirect = getbool (annexConfig "direct") False
, annexBackend = maybe , annexBackend = maybe

10
doc/git-annex.mdwn
View file

@ -822,12 +822,12 @@ repository, using [[git-annex-config]]. See its man page for a list.)
* `annex.diskreserve` * `annex.diskreserve`
Amount of disk space to reserve. Disk space is checked when transferring Amount of disk space to reserve. Disk space is checked when transferring
content to avoid running out, and additional free space can be reserved annexed content to avoid running out, and additional free space can be
via this option, to make space for more important content (such as git reserved via this option, to make space for other data (such as git
commit logs). Can be specified with any commonly used units, for example, commit logs). Can be specified with any commonly used units, for
"0.5 gb", "500M", or "100 KiloBytes" example, "0.5 gb", "500M", or "100 KiloBytes"
The default reserve is 1 megabyte. The default reserve is 100 megabytes.
* `annex.skipunknown` * `annex.skipunknown`

1
doc/todo/prevent_pulling_unlocked_files_using_all_disk_space_by_default.mdwn
View file

@ -9,6 +9,7 @@ be eaten up by other non-object uses of disk.
Perhaps 1 mb is too small for the default for annex.diskreserve. Even Perhaps 1 mb is too small for the default for annex.diskreserve. Even
10 or 100 mb would leave a lot more margin for other minor uses of disk space. 10 or 100 mb would leave a lot more margin for other minor uses of disk space.
(Update: increased default to 100 mb)
Perhaps there could be another config like annex.diskreserve but that Perhaps there could be another config like annex.diskreserve but that
applies only to populating unlocked files. It could default to some larger applies only to populating unlocked files. It could default to some larger