fix bug where resuming a transfer also started one queued transfer

Assistant/WebApp/DashBoard.hs

@@ -209,16 +209,15 @@ cancelTransfer pause t = do
 startTransfer :: Transfer -> Handler ()
 startTransfer t = do
 	m <- getCurrentTransfers
-	webapp <- getYesod
+	maybe startqueued go (M.lookup t m)
-	let dstatus = daemonStatus webapp
-	let q = transferQueue webapp
-	{- resume a paused transfer -}
-	maybe noop go (M.lookup t m)
-	{- start a queued transfer -}
-	is <- liftIO $ map snd <$> getMatchingTransfers q dstatus (== t)
-	maybe noop start $ headMaybe is
 	where
 		go info = maybe (start info) (resume info) $ transferTid info
+		startqueued = do
+			webapp <- getYesod
+			let dstatus = daemonStatus webapp
+			let q = transferQueue webapp
+			is <- liftIO $ map snd <$> getMatchingTransfers q dstatus (== t)
+			maybe noop start $ headMaybe is
 		resume info tid = do
 			webapp <- getYesod
 			let dstatus = daemonStatus webapp

doc/design/assistant/syncing.mdwn

@@ -3,9 +3,6 @@ all the other git clones, at both the git level and the key/value level.
 
 ## immediate action items
 
-* There's apparently a race, as sometimes pausing a transfer causes it to start
-  one of the other queued transfers.
-
 ## longer-term TODO
 
 * Test MountWatcher on LXDE.