filter out control characters in warning messages

Converted warning and similar to use StringContainingQuotedPath. Most
warnings are static strings, some do refer to filepaths that need to be
quoted, and others don't need quoting.

Note that, since quote filters out control characters of even
UnquotedString, this makes all warnings safe, even when an attacker
sneaks in a control character in some other way.

When json is being output, no quoting is done, since json gets its own
quoting.

This does, as a side effect, make warning messages in json output not
be indented. The indentation is only needed to offset warning messages
underneath the display of the file they apply to, so that's ok.

Sponsored-by: Brett Eisenberg on Patreon

Backend/External.hs

@@ -139,7 +139,8 @@ handleRequest st req whenunavail responsehandler =
 		loop
   where
 	handleExceptionalMessage _ (ERROR err) = do
-		warning ("external special remote error: " ++ err)
+		warning $ UnquotedString $
+			"external special remote error: " ++ err
 		whenunavail
 	handleExceptionalMessage loop (DEBUG msg) = do
 		fastDebug "Backend.External" msg
@@ -237,7 +238,7 @@ newExternalState ebname hasext pid = do
   where
 	basecmd = externalBackendProgram ebname
 	warnonce msg = when (pid == 1) $
-		warning msg
+		warning (UnquotedString msg)
 
 externalBackendProgram :: ExternalBackendName -> String
 externalBackendProgram (ExternalBackendName bname) = "git-annex-backend-X" ++ decodeBS bname

Backend/Hash.hs

@@ -130,7 +130,7 @@ checkKeyChecksum hash key file = catchIOErrorType HardwareFault hwfault $ do
 		_ -> return True
   where
 	hwfault e = do
-		warning $ "hardware fault: " ++ show e
+		warning $ UnquotedString $ "hardware fault: " ++ show e
 		return False
 
 sameCheckSum :: Key -> String -> Bool