mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

assistant: Committing a whole lot of files at once could overflow command-line length limits and cause the commit to fail. This only happened when using the assistant in an indirect mode repository.

Browse source
This commit is contained in:
Joey Hess 2015-03-26 14:02:35 -04:00
parent 7cb2f91f5b
commit 2b7f3ee3f2
3 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
doc/bugs/assistant_committer_crash_on_OSX_when_adding_lots_of_files.mdwn
View file

@ -8,3 +8,15 @@ long)
</pre>
Probably need to tune the command length limit for !linux. --[[Joey]]
> Investigation suggests this is the problem:
inRepo (Git.LsFiles.notInRepo False $ map changeFile pending)
> If a lot of new files have been added, the `pending` list can be
> arbitrarily large, and this passes it to git ls-files as parameters.a
>
> It's not the actual commit that fails; that uses Git.Queue and xargs.
> --[[Joey]]
>> [[fixed|done]] --[[Joey]]