mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

use separate main repo dir for each test suite pass

Browse source 
This way a failure to clean up the main repo dir from a previous pass
can't result in reusing that repo, which won't be configured right for the
current pass.
This commit is contained in:
Joey Hess 2019-08-08 14:29:28 -04:00
parent 70b71bf660
commit 298812a353
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 36 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

17
doc/bugs/windows_test_suite_fails_to_init_direct_mode_repo.mdwn
View file

@ -2,16 +2,13 @@ For some reason the test suite on windows is failing to set up the direct
mode repo; git-annex direct fails because the repo is a v7 repo in adjusted
unlocked mode.
It seems it's not running git-annex init with --version=5,
or it does and it gets ignored.
I have not managed to reproduce this outside of the test suite.
I wonder if perhaps the environment variable that the test suite sets
to communicate with itself is not working on Windows, which sometimes
has gotchas around environment variables. --[[Joey]]
Hmm, I reordered the direct mode tests to come first, and the failure went
away. Think that .t/repo gets reused, and being already a v7 repo, git annex
init --version=7 silently did not change it. (Made that error out.)
So the test suite should use different paths for the base repo in each test
pass.
away. Think that .t/repo gets reused somehow, and being already a v7 repo,
git annex init --version=7 silently did not change it. (Now it will error
out instead.)
.t/repo is supposed to be deleted between each pass, but deleting
directories on Windows is a fairly probabalistic venture. It would be
better to use a different repo path for each pass. [[done]] --[[Joey]]