mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

convert to withCreateProcess for async exception safety

Browse source 
This handles all createProcessSuccess callers, and aside from process
pools, the complete conversion of all process running to async exception
safety should be complete now.

Also, was able to remove from Utility.Process the old API that I now
know was not a good idea. And proof it was bad: The code size went *down*,
despite there being a fair bit of boilerplate for some future API to
reduce.
This commit is contained in:
Joey Hess 2020-06-04 15:36:34 -04:00
parent 12e7d52c8b
commit 2670890b17
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
16 changed files with 196 additions and 191 deletions
Download patch file Download diff file Expand all files Collapse all files

16
doc/todo/more_extensive_retries_to_mask_transient_failures/comment_13_6e5fb676ae08026abeb500d01ab86414._comment Normal file
View file

@ -0,0 +1,16 @@
[[!comment format=mdwn
username="joey"
subject="""comment 13"""
date="2020-06-04T19:39:23Z"
content="""
I've converted everything to withCreateProcess, except for process pools
(P2P.IO, Assistant.TransferrerPool, Utility.CoProcess, and Remote.External),
which need to be handled as discussed in comment 8.
During this conversion, I did not watch out for interactive processes that
might block on a password, so any timeout would also affect them. Really,
I don't see a good way to avoid that. Any ssh may or may not need a
password. I guess timeouts will need to affect things stuck on passwords
too, which argues for no default timeout, but otherwise is probably ok
as long as timeouts can be configured on a per-remote basis.
"""]]