Merge branch 'master' of ssh://git-annex.branchable.com

This commit is contained in:
Joey Hess 2021-02-22 12:13:20 -04:00
commit 266f779e84
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
6 changed files with 136 additions and 0 deletions

View file

@ -0,0 +1,48 @@
### Please describe the problem.
git-annex upgrades the repository before I could set the annex.autoupgraderepository to false
### What steps will reproduce the problem?
Its not trivial to reproduce. After an auto upgrade at one repo from v5 to v8 crashed, I decided to freeze all my v5 repositories first. By requiring the repo version and then immediately setting autoupgrade to false I realized the repo was upgraded during the command `git annex config --set autoupgraderepository false`
### What version of git-annex are you using? On what operating system?
git-annex version: 8.20200226
ubuntu 20.04
### Please provide any additional information below.
[[!format sh """
$ git annex version
git-annex version: 8.20200226
build flags: Assistant Webapp Pairing S3 WebDAV Inotify DBus DesktopNotify TorrentParser MagicMime Feeds Testsuite
dependency versions: aws-0.20 bloomfilter-2.0.1.0 cryptonite-0.25 DAV-1.3.3 feed-1.0.1.0 ghc-8.6.5 http-client-0.5.14 persistent-sqlite-2.9.3 torrent-10000.1.1 uuid-1.3.13 yesod-1.6.0
key/value backends: SHA256E SHA256 SHA512E SHA512 SHA224E SHA224 SHA384E SHA384 SHA3_256E SHA3_256 SHA3_512E SHA3_512 SHA3_224E SHA3_224 SHA3_384E SHA3_384 SKEIN256E SKEIN256 SKEIN512E SKEIN512 BLAKE2B256E BLAKE2B256 BLAKE2B512E BLAKE2B512 BLAKE2B160E BLAKE2B160 BLAKE2B224E BLAKE2B224 BLAKE2B384E BLAKE2B384 BLAKE2BP512E BLAKE2BP512 BLAKE2S256E BLAKE2S256 BLAKE2S160E BLAKE2S160 BLAKE2S224E BLAKE2S224 BLAKE2SP256E BLAKE2SP256 BLAKE2SP224E BLAKE2SP224 SHA1E SHA1 MD5E MD5 WORM URL
remote types: git gcrypt p2p S3 bup directory rsync web bittorrent webdav adb tahoe glacier ddar git-lfs hook external
operating system: linux x86_64
supported repository versions: 8
upgrade supported from repository versions: 0 1 2 3 4 5 6 7
local repository version: 5
$ git annex config --set autoupgraderepository false
autoupgraderepository false ok
(recording state in git...)
$ git annex version
git-annex version: 8.20200226
build flags: Assistant Webapp Pairing S3 WebDAV Inotify DBus DesktopNotify TorrentParser MagicMime Feeds Testsuite
dependency versions: aws-0.20 bloomfilter-2.0.1.0 cryptonite-0.25 DAV-1.3.3 feed-1.0.1.0 ghc-8.6.5 http-client-0.5.14 persistent-sqlite-2.9.3 torrent-10000.1.1 uuid-1.3.13 yesod-1.6.0
key/value backends: SHA256E SHA256 SHA512E SHA512 SHA224E SHA224 SHA384E SHA384 SHA3_256E SHA3_256 SHA3_512E SHA3_512 SHA3_224E SHA3_224 SHA3_384E SHA3_384 SKEIN256E SKEIN256 SKEIN512E SKEIN512 BLAKE2B256E BLAKE2B256 BLAKE2B512E BLAKE2B512 BLAKE2B160E BLAKE2B160 BLAKE2B224E BLAKE2B224 BLAKE2B384E BLAKE2B384 BLAKE2BP512E BLAKE2BP512 BLAKE2S256E BLAKE2S256 BLAKE2S160E BLAKE2S160 BLAKE2S224E BLAKE2S224 BLAKE2SP256E BLAKE2SP256 BLAKE2SP224E BLAKE2SP224 SHA1E SHA1 MD5E MD5 WORM URL
remote types: git gcrypt p2p S3 bup directory rsync web bittorrent webdav adb tahoe glacier ddar git-lfs hook external
operating system: linux x86_64
supported repository versions: 8
upgrade supported from repository versions: 0 1 2 3 4 5 6 7
local repository version: 8
# End of transcript or log.
"""]]
### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
I am using it since v5 and only v5 for repos like more 100k filecount and size ~800GB. Worked perfectly on Linux desktop, android, phone, tab, raspberry. The greatest sync tool I ever had. I am a little bit worried about the upgrade to v8 from v5 now :)

View file

@ -0,0 +1,8 @@
[[!comment format=mdwn
username="zsolt1"
avatar="http://cdn.libravatar.org/avatar/ef26f34d5d953cf139c58e5dc4b5fe73"
subject="reproduce"
date="2021-02-20T19:06:44Z"
content="""
disabling auto-upgrade was successful by 4 repos before I experienced this problem by the 5th one
"""]]

View file

@ -0,0 +1,8 @@
[[!comment format=mdwn
username="Lukey"
avatar="http://cdn.libravatar.org/avatar/c7c08e2efd29c692cc017c4a4ca3406b"
subject="comment 2"
date="2021-02-20T21:35:05Z"
content="""
You're supposed to use `git config annex.autoupgraderepository false`.
"""]]

View file

@ -0,0 +1,8 @@
[[!comment format=mdwn
username="zsolt1"
avatar="http://cdn.libravatar.org/avatar/ef26f34d5d953cf139c58e5dc4b5fe73"
subject="comment 3"
date="2021-02-21T18:11:33Z"
content="""
@Lukey , thanks for pointing it out! Layer 8.
"""]]

View file

@ -0,0 +1,55 @@
## Steps to reproduce:
- create 2 separate repos
- Top right: Repository: path dropdown
- Select the other repository
## Expected result
I expect the UI to switch over to the other repo.
## Actual result
```
Internal Server Error
HttpExceptionRequest Request {
host = "127.0.0.1"
port = 52482
secure = False
requestHeaders = [("Accept-Encoding","")]
path = "/"
queryString = "?auth=REDACTED"
method = "HEAD"
proxy = Nothing
rawBody = False
redirectCount = 10
responseTimeout = ResponseTimeoutDefault
requestVersion = HTTP/1.1
proxySecureMode = ProxySecureWithConnect
}
(ConnectionFailure Network.Socket.connect: <socket: 51>: does not exist (Connection refused))
```
## Context
```
git-annex version: 8.20210127
build flags: Assistant Webapp Pairing FsEvents TorrentParser MagicMime Feeds Testsuite S3 WebDAV
dependency versions: aws-0.22 bloomfilter-2.0.1.0 cryptonite-0.28 DAV-1.3.4 feed-1.3.0.1 ghc-8.10.3 http-client-0.7.4 persistent-sqlite-2.11.0.0 torrent-10000.1.1 uuid-1.3.13 yesod-1.6.1.0
key/value backends: SHA256E SHA256 SHA512E SHA512 SHA224E SHA224 SHA384E SHA384 SHA3_256E SHA3_256 SHA3_512E SHA3_512 SHA3_224E SHA3_224 SHA3_384E SHA3_384 SKEIN256E SKEIN256 SKEIN512E SKEIN512 BLAKE2B256E BLAKE2B256 BLAKE2B512E BLAKE2B512 BLAKE2B160E BLAKE2B160 BLAKE2B224E BLAKE2B224 BLAKE2B384E BLAKE2B384 BLAKE2BP512E BLAKE2BP512 BLAKE2S256E BLAKE2S256 BLAKE2S160E BLAKE2S160 BLAKE2S224E BLAKE2S224 BLAKE2SP256E BLAKE2SP256 BLAKE2SP224E BLAKE2SP224 SHA1E SHA1 MD5E MD5 WORM URL X*
remote types: git gcrypt p2p S3 bup directory rsync web bittorrent webdav adb tahoe glacier ddar git-lfs httpalso borg hook external
operating system: darwin x86_64
supported repository versions: 8
upgrade supported from repository versions: 0 1 2 3 4 5 6 7
local repository version: 8
```
This is macOS 11.2.1 (Big Sur), installed via `brew install git-annex`. I've tried the same behaviour on 2 separate macs, same error both times. It seems like the switching in the web UI is a bit tricky. I've also tried a few browsers (Safari, Chrome) and my dev browser without any ad blocking. It seems like there's an HTTP request to `/config/repository/switchto/...` which returns a 500.
## Workaround
It seems that if I stop the webapp, and start it again, it has actually switched repos. So it's a bit inconvenient, but usable nonetheless.
## Thanks
I've just started the missing of moving from nextcloud to git-annex after the second random deletion of data by nextcloud. I'm deeply grateful to the authors for giving me the confidence of git to manage my files. Wonderful.

View file

@ -0,0 +1,9 @@
[[!comment format=mdwn
username="git-annex.branchable.com@d12f3f46c9222459d17f96bc7be04f7cd03a6732"
nickname="git-annex.branchable.com"
avatar="http://cdn.libravatar.org/avatar/e3748ecfbbcafc96ccec69fb2db01c3f"
subject="comment 1"
date="2021-02-21T15:50:47Z"
content="""
Apologies, I realise I think I filed this as a \"todo\" instead of under \"bugs\", apologies. I can't see how to move it unfortunately...
"""]]