update on S3 memory leaks

The remaining leaks are in hS3. The leak with encryption was worked around
by the use of the temp file. (And was probably originally caused by
gpgCipherHandle sparking a thread which kept a reference to the start
of the byte string.)
This commit is contained in:
Joey Hess 2011-04-21 11:06:29 -04:00
parent 45bdb2d413
commit 2467c56771
2 changed files with 4 additions and 14 deletions

3
debian/changelog vendored
View file

@ -3,8 +3,7 @@ git-annex (0.20110420) UNRELEASED; urgency=low
* Update Debian build dependencies for ghc 7.
* Debian package is now built with S3 support.
Thanks Joachim Breitner for making this possible.
* No longer needs to buffer entire files when sending them to S3.
(However, getting files from S3 still requires buffering.)
* Somewhat improved memory usage of S3, still work to do.
Thanks Greg Heartsfield for ongoing work to improve the hS3 library
for git-annex.

View file

@ -1,17 +1,8 @@
S3 has memory leaks
## with encryption
Sending a file to S3 causes a slow memory increase toward the file size.
One only occurs with encryption. It was was fixed for bup, but
not yet for S3, in 5985acdfad8a6791f0b2fc54a1e116cee9c12479.
(The fix I used for bup doesn't seem to work with S3.)
## always
Copying the file back from S3 causes a slow memory increase toward 119 mb.
Copying the file back from S3 causes a slow memory increase toward the
file size.
The author of hS3 is aware of the problem, and working on it.
## fixed
memory leak while uploading content to S3