This commit is contained in:
Joey Hess 2018-05-15 11:54:02 -04:00
parent 47ff8fa976
commit 2463d4b855
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 43 additions and 0 deletions

View file

@ -0,0 +1,22 @@
[[!comment format=mdwn
username="joey"
subject="""comment 2"""
date="2018-05-15T15:37:57Z"
content="""
This has nothing to do with direct mode or v6, or the filesystem.
It is behaving more or less as intended.
Filenames in views are always mangled to make them guaranteed to be
unique, since two files with base name "foo" could be collected into the
same view directory. This is done by embedding the directory structure
inside the filename as you show.
In the specific case of "/=*" that is not necessary since the view
is replicating the full directory structure. But most views do need
the mangling, and I feel it's better to always do the mangling than try to
work out when it's not needed.
And "/=*" is a mostly not useful edge case in the actual useful functionality
of views. Note my comment in the http://git-annex.branchable.com/forum/How_to_hide_broken_symlinks/
forum post; it's not really a good way to hide missing files.
"""]]

View file

@ -0,0 +1,21 @@
[[!comment format=mdwn
username="joey"
subject="""comment 4"""
date="2018-05-14T17:30:25Z"
content="""
It's caused by git submodules with names starting with dots. Not at all
related to the recent null pointer dereference bug in git-annex.
The .heudiconv/ directory is a submodule and git ls-files lists it; the view
generation code assumes it's a dotfile and asks git to hash it.
joey@darkstar:~/tmp/1038_hyperface.x>git hash-object -w --stdin-paths --no-filters
.heudiconv
fatal: Unable to add (null) to database
Views only include dotfiles to make .gitattributes etc work, and they don't
include submodules normally, but they do include dot-dirs too; indeed I see
this repository uses that with a .datalad/ that gets included in the view.
Perhaps .heudiconv/ is a similar dot-dir. Seems that such submodule
dot-dirs ought to be included in the view.
"""]]