mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

am I silly to worry about length overflowing int max?

Browse source
This commit is contained in:
Joey Hess 2011-05-16 22:22:37 -04:00
parent 5068985020
commit 21953a802a
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Command/Status.hs
View file

@ -38,10 +38,13 @@ data StatInfo = StatInfo
-- a state monad for running Stats in -- a state monad for running Stats in
type StatState = StateT StatInfo Annex type StatState = StateT StatInfo Annex
type SizeList a = ([a], Int) -- a list with a known length
-- (Integer is used for the length to avoid
-- blowing up if someone annexed billions of files..)
type SizeList a = ([a], Integer)
sizeList :: [a] -> SizeList a sizeList :: [a] -> SizeList a
sizeList l = (l, length l) sizeList l = (l, genericLength l)
command :: [Command] command :: [Command]
command = [repoCommand "status" (paramNothing) seek command = [repoCommand "status" (paramNothing) seek
@ -163,7 +166,7 @@ keySizeSum :: SizeList Key -> StatState String
keySizeSum (keys, len) = do keySizeSum (keys, len) = do
let knownsize = catMaybes $ map keySize keys let knownsize = catMaybes $ map keySize keys
let total = roughSize storageUnits False $ foldl (+) 0 knownsize let total = roughSize storageUnits False $ foldl (+) 0 knownsize
let missing = len - length knownsize let missing = len - genericLength knownsize
return $ total ++ return $ total ++
if missing > 0 if missing > 0
then " (but " ++ show missing ++ " keys have unknown size)" then " (but " ++ show missing ++ " keys have unknown size)"