mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

v6: Close pointer file handles more quickly, to avoid problems on Windows.

Browse source 
Was using L.readFile, so the Handle would remain open until the garbage
collector got around to it. Changed to explicit open and close, so we know
it's always closed when the function returns.
This commit is contained in:
Joey Hess 2016-04-04 15:42:33 -04:00
parent cfe274e6f7
commit 2046502407
Failed to extract signature
4 changed files with 30 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

20
doc/bugs/Windows__58___git_annex_get_failed/comment_2_0866038e64aa20c3b9ba3b3190074293._comment Normal file
View file

@ -0,0 +1,20 @@
[[!comment format=mdwn
username="joey"
subject="""comment 2"""
date="2016-04-04T19:24:08Z"
content="""
Note that v6 mode is still considered experimental.
I know that I saw a problem like this, where git-annex was reading the
pointer file and didn't always get around to closing it before it tried to
replace it. I thought I fixed it back in February though -- but that fix
may have bit rotted; looking at the current code, I think it could leave
the file open until a GC pass, so if the GC doesn't always
run in time, that could explain the reported indeterminacy.
Please paste the actual version of git-annex you're using,
"latest build from source" is a little bit vague.
Since you are building from source, you might try pulling;
I've made a change that may fix it again.
"""]]